Repository navigation
fix: let PipelineBoard card content form its own accessible name - #738
Open
smartcalsystems-sketch wants to merge 1 commit into
Open
smartcalsystems-sketch wants to merge 1 commit into
smartcalsystems-sketch wants to merge 1 commit into
Conversation
MergeFi#694) Each pipeline card's <Link> had aria-label={`${title}, ${reward}`}, which overrides the link's visible content as far as assistive tech is concerned. The org/repo #N line -- the main way a maintainer identifies which issue a card is -- was never announced, only the title and reward the aria-label spelled out manually. Dropped the aria-label so the link's accessible name is computed from its actual visible content instead, which already includes the org/repo reference, the title, and the formatted reward -- nothing is lost, the repo reference is gained.
|
@smartcalsystems-sketch is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Each pipeline card's
<Link>hasaria-label={${title}, ${reward}}, which overrides the link's visible content for assistive tech. Theorg/repo #Nline — the main way a maintainer identifies which issue a card is — is never announced; only the title and reward thearia-labelspells out manually are.Fix
Dropped the
aria-labelso the link's accessible name is computed from its actual visible content instead (theorg/repo #Nline, the title, and the formatted reward are all already rendered inside it) — nothing is lost, the repo reference is gained.Note for maintainers: the issue mentions this is the same pattern used in
BountyCard.tsx, and that's still accurate — I left it untouched since it's a separate component outside this issue's scope, but it likely wants the identical fix in a follow-up.Testing
aria-labelprovided.PipelineBoard.test.tsxsuite: 8/8 passing (7 pre-existing + 1 new), zero regressions.tsc --noEmitandeslintclean on both changed files.Closes #694