Skip to content

fix: let PipelineBoard card content form its own accessible name - #738

Open
smartcalsystems-sketch wants to merge 1 commit into
MergeFi:mainfrom
smartcalsystems-sketch:fix-pipelineboard-card-arialabel-694
Open

smartcalsystems-sketch wants to merge 1 commit into
MergeFi:mainfrom
smartcalsystems-sketch:fix-pipelineboard-card-arialabel-694

Conversation

@smartcalsystems-sketch

Copy link
Copy Markdown

Problem

Each pipeline card's <Link> has aria-label={${title}, ${reward}}, which overrides the link's visible content for assistive tech. The org/repo #N line — the main way a maintainer identifies which issue a card is — is never announced; only the title and reward the aria-label spells out manually are.

Fix

Dropped the aria-label so the link's accessible name is computed from its actual visible content instead (the org/repo #N line, the title, and the formatted reward are all already rendered inside it) — nothing is lost, the repo reference is gained.

Note for maintainers: the issue mentions this is the same pattern used in BountyCard.tsx, and that's still accurate — I left it untouched since it's a separate component outside this issue's scope, but it likely wants the identical fix in a follow-up.

Testing

  • Added a test asserting the card link's accessible name includes the org/repo/issue reference, the title, and the reward — not just the two the old aria-label provided.
  • Full PipelineBoard.test.tsx suite: 8/8 passing (7 pre-existing + 1 new), zero regressions.
  • tsc --noEmit and eslint clean on both changed files.

Closes #694

 MergeFi#694)

Each pipeline card's <Link> had aria-label={`${title}, ${reward}`}, which
overrides the link's visible content as far as assistive tech is
concerned. The org/repo #N line -- the main way a maintainer identifies
which issue a card is -- was never announced, only the title and reward
the aria-label spelled out manually.

Dropped the aria-label so the link's accessible name is computed from
its actual visible content instead, which already includes the org/repo
reference, the title, and the formatted reward -- nothing is lost,
the repo reference is gained.
@vercel

vercel Bot commented Oct 13, 2026

Copy link
Copy Markdown

@smartcalsystems-sketch is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PipelineBoard card links use aria-label, which hides the repo/issue reference from screen readers

1 participant