Skip to content

fix: let PipelineBoard card content form its own accessible name #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smartcalsystems-sketch wants to merge 1 commit into from
Closed

fix: let PipelineBoard card content form its own accessible name #738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/app/dashboard/maintainer/PipelineBoard.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,30 @@ function makeBounty(overrides: Partial<Bounty> = {}): Bounty {
};
}

describe("PipelineBoard — card accessible name (#694)", () => {
it("announces the org/repo/issue reference as part of the link's accessible name", () => {
const bounty = makeBounty({
org: "SmartDropLabs",
repo: "smartdrop-backend",
issueNumber: 42,
title: "Fix retry backoff jitter",
reward: 500,
asset: "USDC",
status: "open",
});
render(<PipelineBoard bounties={[bounty]} />);

const link = screen.getByRole("link", {
name: /SmartDropLabs\/smartdrop-backend #42/,
});
// The accessible name is computed from visible content (no aria-label
// override), so the title and reward are present too, not just the repo
// reference.
expect(link).toHaveAccessibleName(/Fix retry backoff jitter/);
expect(link).toHaveAccessibleName(/500/);
});
});

describe("PipelineBoard — merged column (#88)", () => {
it("renders a bounty with status 'merged' in a visible pipeline column", () => {
const merged = makeBounty({ id: "merged-1", title: "Merged, awaiting payout", status: "merged" });
Expand Down
1 change: 0 additions & 1 deletion src/app/dashboard/maintainer/PipelineBoard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ function PipelineColumn({
key={b.id}
href={`/issues/${b.id}`}
title={b.title}
aria-label={`${b.title}, ${formatCurrency(b.reward, b.asset)}`}
className="block rounded-xl border border-slate-200 bg-white p-3 shadow-sm transition-colors hover:border-indigo-300 focus-visible:outline-2 focus-visible:outline-offset-2 focus-visible:outline-indigo-500 dark:border-slate-800 dark:bg-slate-900 dark:hover:border-indigo-700"
>
<p className="truncate text-xs text-slate-400 dark:text-slate-500">
Expand Down