Repository navigation
chore: remove unused UserMenu, move handleSignOut to shared-actions; codegen docs - #54
Merged
Merged
Conversation
…is run Every direct `tsx` command for generate-types / generate-storedprocs in the READMEs and references now carries the flag, with a note on why (`server-only` in the MP client modules). The CLIs' own --help text points at the npm scripts, which already pass it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The project will not use the dropdown UserMenu (it was never mounted). `handleSignOut` is still needed by /session-error, so it moves to `src/components/shared-actions/sign-out.ts` with its tests. Drops @heroicons/react, which only the menu used. Docs updated to match, including that /session-error holds the app's only sign-out control. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
chriskehayias
added a commit
that referenced
this pull request
Oct 10, 2026
Sign-in isn't role-gated, so a user with no MP security role gets a session and lands on `/no-access`. With `UserMenu` removed (#54), nothing let them end that session before the 12-hour limit. - `/no-access` now has a **Sign out** form wired to `handleSignOut`, the same pattern as `/session-error`. The page stays dynamic because it renders under AuthWrapper, so the CSP nonce is present. - Added a test that pins the submit button and form. - Updated the docs (security, oauth-flow, the sign-out call graph, shared-actions README, README) to name both sign-out forms. **Verified** against a production build with the CSP enforced. Clicking Sign out on `/no-access` went to MP's logout page, back to the app, through `/signin`, and stopped at the MP login prompt, so both sessions ended. No CSP violations. `lint`, `typecheck` and `test:coverage` pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UserMenu removal
The project won't use the dropdown
UserMenu, which was never mounted anywhere.src/components/user-menu/(component, barrel, component test).handleSignOutis still used by the/session-errorform, so it moved with its tests tosrc/components/shared-actions/sign-out.ts. Imports and code comments are updated.@heroicons/react, which only the menu used. The vendored shadcndropdown-menuprimitive stays.components/user-menu.md; updated auth, data-flow (sign-out call graph rewritten to match the current action), GLOSSARY, GOTCHAS, security, testing inventory, CLAUDE.md and README./session-errorholds the app's only sign-out control and/no-accesshas none.Codegen docs
Every direct
tsxcommand forgenerate-typesandgenerate-storedprocs(README, scripts README, the mp-provider reference) now includes--conditions=react-server, with a note on why: the MP client modules useserver-only. The CLIs'--helptext now points to the npm scripts, which already pass the flag.Verification
lint,typecheckandtest:coveragepass (2184 tests; the 7UserMenucomponent tests were removed with it).npm run buildandcheck:prerenderpass.npm run mp:generate:storedprocs -- --helpruns.🤖 Generated with Claude Code