Skip to content

981.update podman build - #982

Open
singhd789 wants to merge 27 commits into
NOAA-GFDL:mainfrom
singhd789:981.update-podman-build
Open

singhd789 wants to merge 27 commits into
NOAA-GFDL:mainfrom
singhd789:981.update-podman-build

Conversation

@singhd789

@singhd789 singhd789 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes

  • add --network host to podman build step (a bit hard to constrain because this workaround is ONLY for GAEA though)
  • adjust tests
  • build_conda.yaml was failing - install libmamba as a conda solver to help build

Issue ticket number and link (if applicable)

Fixes #981

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the release_procedure.md template. To quickly use this template, open a new pull request, choose your branch, and add ?template=release_procedure.md to the end of the url.

Copilot AI balanced review requested due to automatic review settings September 29, 2026 20:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The generated commands use an unsupported podman build --net flag instead of --network.

Review effort: Balanced
Findings: 1 High severity · 1 Medium severity

Open (2)
What changed in this PR

Adds host networking to generated container build commands.

Changes:

  • Adds host networking to builds with and without volume mounts.
  • Updates the generated-script test expectation.
File Description
fre/​make/​gfdlfremake/​buildDocker.py Adds host networking to container builds.
fre/​make/​tests/​test_create_dockerfile.py Updates the expected build command.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread fre/make/gfdlfremake/buildDocker.py Outdated
Comment thread fre/make/tests/test_create_dockerfile.py Outdated
@singhd789 singhd789 linked an issue Sep 29, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.46%. Comparing base (a256a36) to head (0fd57f8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
+ Coverage   83.45%   83.46%   +0.01%     
==========================================
  Files          68       68              
  Lines        3808     3811       +3     
==========================================
+ Hits         3178     3181       +3     
  Misses        630      630              
Flag Coverage Δ
unittests 83.46% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
fre/make/gfdlfremake/buildDocker.py 91.20% <100.00%> (+0.21%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a256a36...0fd57f8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Dana Singh added 2 commits October 1, 2026 15:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Host networking is incorrectly applied to Docker builds as well as Podman builds.

Review effort: Balanced
Findings: 1 Medium severity · 1 Low severity

Open (2)
Resolved since last review (2)

Comment thread fre/make/gfdlfremake/buildDocker.py Outdated
Comment thread fre/make/tests/test_create_dockerfile.py Outdated
Comment thread .github/workflows/build_conda.yml Outdated
run: |
echo "conda install conda-build"
conda install conda-forge::conda-build
conda install conda-forge::conda-build=25.*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is conda-build version 25 required? Should we use greater than or equal instead of equals?

@singhd789 singhd789 Oct 13, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might not be. I forgot why I added that. Maybe I thought it fixed a different problem. I'm trying to get the pipeline build test to work at the moment (the conda package build works now but the test for the build was failing 😢 ) in a different PR and I'll see if I can keep this version pinning out.

Comment thread fre/make/tests/test_create_dockerfile.py

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fre make: podman build command needs an update

3 participants