Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The generated commands use an unsupported podman build --net flag instead of --network.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds host networking to generated container build commands.
Changes:
- Adds host networking to builds with and without volume mounts.
- Updates the generated-script test expectation.
| File | Description |
|---|---|
fre/make/gfdlfremake/buildDocker.py |
Adds host networking to container builds. |
fre/make/tests/test_create_dockerfile.py |
Updates the expected build command. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…inghd789/fre-cli into 981.update-podman-build
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #982 +/- ##
==========================================
+ Coverage 83.45% 83.46% +0.01%
==========================================
Files 68 68
Lines 3808 3811 +3
==========================================
+ Hits 3178 3181 +3
Misses 630 630
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
…inghd789/fre-cli into 981.update-podman-build
…inghd789/fre-cli into 981.update-podman-build
| run: | | ||
| echo "conda install conda-build" | ||
| conda install conda-forge::conda-build | ||
| conda install conda-forge::conda-build=25.* |
There was a problem hiding this comment.
Is conda-build version 25 required? Should we use greater than or equal instead of equals?
There was a problem hiding this comment.
It might not be. I forgot why I added that. Maybe I thought it fixed a different problem. I'm trying to get the pipeline build test to work at the moment (the conda package build works now but the test for the build was failing 😢 ) in a different PR and I'll see if I can keep this version pinning out.



Describe your changes
--network hostto podman build step (a bit hard to constrain because this workaround is ONLY for GAEA though)libmambaas a conda solver to help buildIssue ticket number and link (if applicable)
Fixes #981
Checklist before requesting a review
Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the
release_procedure.mdtemplate. To quickly use this template, open a new pull request, choose your branch, and add?template=release_procedure.mdto the end of the url.