Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
c9d7759
#981 update podman build
Sep 29, 2026
31a467f
Merge branch 'main' into 981.update-podman-build
singhd789 Sep 29, 2026
e9230e9
#981 add --net=host
Sep 29, 2026
d6fd6c0
#981 Merge branch '981.update-podman-build' of github.com:singhd789/…
Sep 29, 2026
2e98edc
Merge branch 'main' into 981.update-podman-build
singhd789 Oct 1, 2026
3e15fb5
#981 update `net` to `network`
Oct 1, 2026
35b735d
#981 Merge branch '981.update-podman-build' of github.com:singhd789/…
Oct 1, 2026
a02094a
#981 attempt to fix conda build
Oct 5, 2026
25c9bbe
#981 try using classic conda solver
Oct 5, 2026
9ddb663
#981 add timeout
Oct 5, 2026
0a7da7a
#981 try libmamba
Oct 5, 2026
63ee19e
#981 try installing libmamba
Oct 5, 2026
fe41b19
#981 no plugins
Oct 5, 2026
1387274
#981 comment out
Oct 5, 2026
74c66c1
#981 set no_plugins for just the test of the build
Oct 5, 2026
b380430
#981 add libmamba solver to test env
Oct 5, 2026
a15ee01
#981 check for codna build
Oct 6, 2026
297b9dd
#981 test conda-build and plugins
Oct 6, 2026
b560809
#981 do plugins work?
Oct 6, 2026
43ce6aa
#981 clean up
Oct 6, 2026
7c74170
#981 address comment
Oct 6, 2026
b9a3855
#981 workaround only for podman
Oct 8, 2026
b6c65c1
Merge branch 'main' into 981.update-podman-build
singhd789 Oct 9, 2026
8f05372
#981 try pinning versions
Oct 9, 2026
42228dd
#981 Merge branch '981.update-podman-build' of github.com:singhd789/…
Oct 9, 2026
c4963ae
#981 typo
Oct 9, 2026
0fd57f8
#981 remove conda build version pin
Oct 13, 2026
219a553
Merge branch 'main' into 981.update-podman-build
singhd789 Oct 15, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions fre/make/gfdlfremake/buildDocker.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,10 +236,16 @@ def createBuildScript(self, platform, skip_format_transfer):
platform_tag = self.target.gettargetName().lower()

self.userScript = ["#!/bin/bash\n", "set -ex\n"]

# Construct container build command
self.userScript.append(f"{containerBuild} build ")
if containerBuild == "podman":
self.userScript.append("--network host ")
if container_volume:
self.userScript.append(f"{containerBuild} build --volume {container_volume}:{container_volume} -f Dockerfile -t {registry_tag}:{platform_tag}\n")
else:
self.userScript.append(f"{containerBuild} build -f Dockerfile -t {registry_tag}:{platform_tag}\n")
self.userScript.append(f"--volume {container_volume}:{container_volume} " )

self.userScript.append(f"-f Dockerfile -t {registry_tag}:{platform_tag}\n")


if not skip_format_transfer:
# Remove any previously generated images, if they exist
Expand Down
2 changes: 1 addition & 1 deletion fre/make/tests/compilation/test_run_fremake_builds.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,5 +142,5 @@ def test_run_fremake_container_build_fail():
stderr = run.stderr

#Check that the incorrect line specifically prints in the stderr
fail_step = "podman build -f Dockerfile-wrong"
fail_step = "podman build --network host -f Dockerfile-wrong"
assert fail_step in str(stderr)
3 changes: 2 additions & 1 deletion fre/make/tests/test_create_dockerfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ def test_build_script_contents():
with open('createContainer.sh', 'r') as f:
lines = f.readlines()

expected_volume_mount = "podman build --volume /gpfs/f5:/gpfs/f5 -f Dockerfile -t null_model_full:debug"
expected_volume_mount = ("podman build --network host --volume /gpfs/f5:/gpfs/f5 "
"-f Dockerfile -t null_model_full:debug")
Comment thread
ceblanton marked this conversation as resolved.

# strip off '\n'
container_build_script = []
Expand Down
Loading