[PointKernel]

Description

This PR adds peak-memory tracking to the remaining join benchmarks, compiles the JIT filter benchmark as C++, and skips invalid multiplicity configurations.

Contributes to #10528; depends on #24730.

Checklist

• I am familiar with the Contributing Guidelines.
• New or existing tests cover these changes.
• The documentation is up to date with these changes.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[PointKernel]

/ok to test a504968

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: NVIDIA/cudf/.coderabbit.yaml
• Review profile: CHILL
• Plan: Enterprise
• Run ID: d9fdd25f-572e-4b4a-922a-2e4e1e6f1a8e

📥 Commits

Reviewing files that changed from the base of the PR and between 8fc209e and a504968.

📒 Files selected for processing: 8

• cpp/benchmarks/CMakeLists.txt
• cpp/benchmarks/join/direct_join.cu
• cpp/benchmarks/join/filter_join_indices_jit.cpp
• cpp/benchmarks/join/join_common.hpp
• cpp/benchmarks/join/join_heuristics.cpp
• cpp/benchmarks/join/join_on_int32.cu
• cpp/benchmarks/join/key_remap_build.cpp
• cpp/benchmarks/join/sort_merge_join.cpp

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

📝 Summary

Summary by CodeRabbit

• New Features

  • Join benchmarks now report peak GPU memory usage alongside existing performance metrics.
  • Memory tracking is available across direct join, filtered join, heuristic, INT32, key-remapping, and sort-merge join benchmarks.

• Bug Fixes

  • Join benchmarks now skip invalid configurations where the requested multiplicity exceeds the available build-side rows.

• Chores

  • Updated the JOIN benchmark build target to use the correct implementation source.

Join benchmarks now record peak memory usage. The shared join benchmark skips cases where multiplicity exceeds right_size. The JOIN benchmark target now compiles the JIT filter benchmark’s C++ source.

Changes: Join benchmark updates

Layer / File(s)	Summary
Shared join validation and memory metrics cpp/benchmarks/join/join_common.hpp, cpp/benchmarks/join/direct_join.cu	BM_join skips when multiplicity exceeds right_size. Both benchmarks record peak memory usage.
JIT filter benchmark source and metric cpp/benchmarks/CMakeLists.txt, cpp/benchmarks/join/filter_join_indices_jit.cpp	The JOIN target uses the .cpp source. The filter benchmark records peak memory usage.
Additional join benchmark memory metrics cpp/benchmarks/join/join_heuristics.cpp, cpp/benchmarks/join/join_on_int32.cu, cpp/benchmarks/join/key_remap_build.cpp, cpp/benchmarks/join/sort_merge_join.cpp	The heuristics, INT32 join, key remapping, and sort-merge benchmarks record peak memory usage.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Suggested reviewers: davidwendt, vyasr

Merge Risk: ⚪ Minimal · up to a5049

No merge-blocking risk is established by the reviewed changes.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 7 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the primary change: tracking peak memory in join benchmarks. It also covers the main objective of the pull request.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description check		The pull request description directly matches the changes. It covers peak-memory tracking, C++ compilation for the JIT filter benchmark, and invalid multiplicity handling.

Full details: Docstring Coverage

Explanation

Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 7 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}