Repository navigation
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the custom mutable-string and raw-storage device-view wrappers with operations on the core column device views. Add mutable_string_view for preallocated character storage and repr_element for loading and assigning stored representations.
Remove the column-type template argument from column_accessor and update kernel instantiations, checked arithmetic, URL examples, and the two existing preallocated-string tests. Reflect the underlying UDF value types separately from accessor tags, and accept PTX as an LTO binary format.
This PR is based on the reflection/storage-helper extraction. List types are not introduced here.
Validation
PR stack
Depends on #24425. List support follows in #24767. This draft targets
main, so its PR diff includes that prerequisite until it merges. The changes specific to this part are in commit650d45372d4794a7c5a265e2670b08dc1de58bcdand this comparison.Checklist