Repository navigation
Fix CI on staging: pin runner to ubuntu-24.04 and Python 3.11 - #1202
Merged
Merged
Conversation
Bornunique911
requested review from
Pa04rth,
northdpole,
paoga87 and
robvanderveer
as code owners
November 4, 2026 17:26
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the
|
Bornunique911
force-pushed
the
importers-links-fixes
branch
from
November 4, 2026 17:42
9719123 to
061c2ac
Compare
Signed-off-by: Bornunique911 <69379200+Bornunique911@users.noreply.github.com>
This was referenced Nov 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a follow-up to #1105, which was merged into
staging. The workflow files onstagingstill carryruns-on: ubuntu-latestandpython-version: '3.12', so CI fails at the "Set up Python" step.This PR applies the same minimal CI fix that #1201 applied to
main, but targetsstagingso that runs onstagingare unblocked and the environment matches the documented Python requirement.Problem Fixed
Both
test.ymlande2e.ymlonstagingfail before any test step can run:runs-on: ubuntu-latest, which GitHub has migrated to Ubuntu 26.04, andpython-version: '3.12', which has no prebuilt binary for Ubuntu 26.04 in theactions/setup-pythonmanifest.The job fails at the "Set up Python" step with an error of the form:
This blocked CI for #1105 and any branch based on
staging.Solution
Two minimal changes in each workflow file on
staging:.github/workflows/e2e.ymlruns-on: ubuntu-latest→ubuntu-24.04;python-version: '3.12'→'3.11'.github/workflows/test.ymlruns-on: ubuntu-latest→ubuntu-24.04;python-version: '3.12'→'3.11'Why
ubuntu-24.04: pins the job to a stable runner image where Python 3.11 builds are available, and prevents futureubuntu-latestmigrations from silently breaking CI onstagingagain.Why
3.11: matches the project's documented requirement..python-versioncontains exactly3.11.9, andREADME.mdstates installation requires Python 3.11.9. Requesting the minor version ('3.11') letssetup-pythonresolve to the latest 3.11 patch from the runner cache, rather than pinning a patch that could disappear from the manifest.Diff
Tests
2 files changed, 4 insertions(+), 4 deletions(-)).ubuntu-24.04.Reviewer Notes
node-versionine2e.ymlis left as-is to keep the fix scoped.actions/checkout@v4,setup-python@v5,setup-node@v4, andupload-artifact@v4are preserved.staging, notmain, because Fix OWASP importer hyperlinks #1105 landed onstagingand its workflow files still carry the broken pins.Related
main)