Repository navigation
refactor: 잔여 하드코딩 문자열 외부화 (:app 바텀네비 + :core:designsystem) - #37
Merged
Merged
Conversation
- `SearchBar`, `CombinationCard` 등 디자인 시스템 컴포넌트 내 하드코딩된 텍스트를 `stringResource`로 변경 - `NavTab`의 `label` 속성 타입을 `String`에서 `@StringRes Int`로 변경하여 리소스 ID를 사용하도록 수정 - `BottomNavBar`에서 변경된 `NavTab` 라벨을 처리할 수 있도록 `stringResource` 적용 - `core/designsystem` 및 `app` 모듈의 `strings.xml`에 관련 문자열 정의 추가
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
:app·:core:designsystem하드코딩 문자열을 string resource 로 외부화.:appNavTab: 바텀네비 라벨(홈·작성·마이)을label: String→@StringRes label: Int로 구조 변경하고BottomNavBar에서stringResource(tab.label)로 해석.app/.../strings.xml에nav_home·nav_create·nav_my추가.:core:designsystem:SearchBar(검색어를 입력하세요placeholder,검색contentDescription),CombinationCard(이미지 없음,좋아요)를 모듈strings.xml(신설)로 외부화.📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
표시 텍스트 동일 — 같은 문자열을 리소스 경유로만 변경. UI 변화 없어 캡처 생략.
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
:app:assembleDebug+lintDebug+ ktlint 1.8.0(로컬) green.NavTab.label의String → @StringRes Int구조 변경 검토 부탁드립니다(생성자 인자라 use-site target@param:StringRes명시, KT-73255 회피).@Composable컨텍스트가 아니라 별도 범위로 제외.