Repository navigation
Sims/optimize doom - #470
Draft
suchmememanyskill wants to merge 6 commits into
Draft
suchmememanyskill wants to merge 6 commits into
suchmememanyskill wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
🔵 Needs a closer look
Safe gameplay during printing requires on-device validation of the buffered simpledrm path’s CPU cost and Klipper timing under concurrent load, which static review cannot establish.
No open issues 🎉
What changed in this PR
This PR aims to reduce Doom’s CPU usage so it can run during printing by optimizing framebuffer scaling and writes.
Changes:
- Replaces bilinear scaling with nearest-neighbour scaling, using precomputed sampling maps, palette lookup, and repeated-row reuse.
- Uses buffered writes for simpledrm and combines tightly packed framebuffer rows into a single transfer.
- Updates the BitBake recipe to apply both optimization patches.
| File | Description |
|---|---|
meta-opencentauri/recipes-apps/doom/files/0004-buffer-simpledrm-framebuffer-writes.patch |
Adds buffered simpledrm writes and coalesces packed-row transfers. |
meta-opencentauri/recipes-apps/doom/files/0003-nearest-neighbour-fit-scaling.patch |
Implements efficient nearest-neighbour scaling while preserving aspect ratio and framebuffer layout handling. |
meta-opencentauri/recipes-apps/doom/fbdoom_0.0.1.bb |
Includes the updated scaling patch and new framebuffer-write patch. |
Review effort: Balanced
✅ Build ArtifactsBranch:
|
✅ Build ArtifactsBranch:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make doom use less CPU so it can be played during printing