Skip to content

ci: the version check counts the CI workflow as build (#42) - #43

Merged
compot-dev merged 2 commits into
masterfrom
check-version-ci-workflow
Oct 18, 2026
Merged

compot-dev merged 2 commits into
masterfrom
check-version-ci-workflow

Conversation

@compot-dev

Copy link
Copy Markdown
Collaborator

Closes #42. cc @keyldev

.github/check-version.sh now counts .github/workflows/ci.yml as build, next to src/, the installers, the Makefile and ci/. The script cannot tell the build steps of the workflow from its tests and publication, so a workflow edit needs either a new CERBERUS_VERSION or the no-release label (#39) when the binaries stay as they are.

This pull request changes only the check script, not the binaries: no-release, no version bump.

Checked locally:

  • shellcheck v0.10.0 -S warning on the script: clean.
  • The script on synthetic commits in a scratch clone:
    • src/ change, no new version → fails; with NO_RELEASE=true → passes with a notice;
    • ci.yml change, no new version → fails; with NO_RELEASE=true → passes with a notice;
    • README only → passes; another file in .github/ → passes.

@compot-dev compot-dev added the no-release Changes the build or the code without changing the binaries: no new version, no release label Oct 18, 2026
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Require a version bump for CI workflow changes

🐞 Bug fix 🕐 Less than 10 minutes

Grey Divider

AI Description

• Include the CI workflow in the version check’s build-change paths.
• Require a version bump for workflow edits unless the PR has a no-release label.
Diagram

graph TD
  A["CI workflow"] --> C["Build-path selection"] --> D{"Version bumped?"} -->|Yes| E["Validate release"] --> H["Accept PR"]
  B["Other build paths"] --> C
  D -->|No| F{"No-release label?"} -->|No| G["Reject PR"]
  F -->|Yes| H
Loading
High-Level Assessment

Adding the exact workflow path to the existing build-path check is the simplest fit. Classifying individual workflow edits as build, test, or publication changes would add complexity; the existing no-release label handles edits that leave binaries unchanged.

Files changed (1) +8 / -5

Bug fix (1) +8 / -5
check-version.shCount the CI workflow as a build path +8/-5

Count the CI workflow as a build path

• Adds .github/workflows/ci.yml to the paths that require a new CERBERUS_VERSION or the no-release exemption. Comments clarify that the whole workflow is covered, while other .github/ files remain exempt.

.github/check-version.sh

@qodo-free-for-open-source-projects

qodo-free-for-open-source-projects Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 🎨 UX issues (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Workflow editors get incorrect version guidance ✓ Resolved
Description
Adding .github/workflows/ci.yml to code makes workflow edits subject to the version check, but
the README still says workflows do not require a new version. A contributor following that guidance
for a workflow-only pull request will see the check fail unless they bump the version or apply
no-release; the version job’s comment also omits the new requirement.
Code

.github/check-version.sh[27]

+code="src install.sh uninstall.sh Makefile ci .github/workflows/ci.yml"
Evidence
The new path is included in the diff check, and unchanged versions with a matching change fail
without NO_RELEASE=true. The README explicitly promises the opposite for workflows, while the
workflow comment lists only the previously checked paths.

.github/check-version.sh[27-27]
.github/check-version.sh[37-57]
README.md[324-329]
.github/workflows/ci.yml[20-23]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The README says workflows are exempt from version bumps, while the check now requires a bump or `no-release` for changes to the CI workflow.
## Fix Focus Areas
- README.md[324-329]
- .github/workflows/ci.yml[20-23]
## Recommended Fix
Describe the CI workflow exception to the general `.github/` exemption in the README, including when `no-release` applies. Update the version job comment to name the CI workflow.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Tip of the day
💡 Did you know, you can move or hide resolved findings to focus on what still needs action

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

Comment thread .github/check-version.sh Resolved
@compot-dev

Copy link
Copy Markdown
Collaborator Author

Qodo finding 1 (README and the version job's comment still said workflows need no new version): fixed in c4a912b. README.md, README.ru.md and README.zh-CN.md now name .github/workflows/ci.yml among the paths that need a new version and list a workflow edit to the tests or the publication among the no-release cases; the comment above the version job says the same. actionlint on ci.yml: clean. This commit touches ci.yml, so the check now runs on it too and passes through the no-release label.

@compot-dev

Copy link
Copy Markdown
Collaborator Author

/review

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Qodo finding 1 (README and the version job's comment still said workflows need no new version): fixed in c4a912b. README.md, README.ru.md and README.zh-CN.md now name .github/workflows/ci.yml among the paths that need a new version and list a workflow edit to the tests or the publication among the no-release cases; the comment above the version job says the same. actionlint on ci.yml: clean. This commit touches ci.yml, so the check now runs on it too and passes through the no-release label.

Thanks for the update. finding 1 appears addressed: all three README variants and the version-job comment now document the CI workflow requirement and the applicable no-release exception. The reported actionlint check is also clean.

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code review by qodo was updated up to the latest commit c4a912b

@compot-dev
compot-dev merged commit 1dbdfec into master Oct 18, 2026
9 checks passed
@compot-dev
compot-dev deleted the check-version-ci-workflow branch October 18, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-release Changes the build or the code without changing the binaries: no new version, no release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version check: count the CI workflow as build

1 participant