Repository navigation
ci: the version check counts the CI workflow as build (#42) - #43
Conversation
PR Summary by QodoRequire a version bump for CI workflow changes
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1.
|
|
Qodo finding 1 (README and the version job's comment still said workflows need no new version): fixed in c4a912b. README.md, README.ru.md and README.zh-CN.md now name |
|
/review |
Thanks for the update. finding 1 appears addressed: all three README variants and the version-job comment now document the CI workflow requirement and the applicable |
|
Code review by qodo was updated up to the latest commit c4a912b |
Closes #42. cc @keyldev
.github/check-version.shnow counts.github/workflows/ci.ymlas build, next tosrc/, the installers, the Makefile andci/. The script cannot tell the build steps of the workflow from its tests and publication, so a workflow edit needs either a newCERBERUS_VERSIONor theno-releaselabel (#39) when the binaries stay as they are.This pull request changes only the check script, not the binaries:
no-release, no version bump.Checked locally:
-S warningon the script: clean.src/change, no new version → fails; withNO_RELEASE=true→ passes with a notice;ci.ymlchange, no new version → fails; withNO_RELEASE=true→ passes with a notice;.github/→ passes.