feat(i18n): add storage details cooldown and timeout setting labels - #641
Open
Vurliy wants to merge 2 commits into
Open
feat(i18n): add storage details cooldown and timeout setting labels#641Vurliy wants to merge 2 commits into
Vurliy wants to merge 2 commits into
Conversation
18 tasks
pikachuren
reviewed
Sep 1, 2026
pikachuren
left a comment
Collaborator
There was a problem hiding this comment.
结论:可以合并,有一处排版建议
只新增两个 i18n key,配合后端的存储详情冷却与超时配置项,改动干净、无副作用。文案表述清晰,把「刷新冷却」和「后台超时」区分得很明确,加了 (seconds) 单位提示也有助于管理员理解填什么值。
一个小建议:src/lang/en/settings.json 现有的 148 个 key 是严格按字母序排列的(我核对过,末尾依次是 upload_task_threads_num、version、video_autoplay、video_types、webauthn_login_enabled)。这次两个新 key 追加在了 webauthn_login_enabled 之后,破坏了这个顺序。按字母序它们应该插到 sso_... 与 token 之间的位置。
这不影响功能,但保持有序在这类文件上有实际价值:新增 key 时容易定位、减少多人同时改动时的冲突,Crowdin 侧的 diff 也更干净。建议调整一下位置。
另外提醒一点节奏问题:这些 key 对应的后端配置项如果尚未合并,前端先合入不会有副作用(多余的 key 只是不被引用),但反过来后端先上线则会显示原始 key 名。建议与后端 PR 协调好先后顺序。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 摘要
1. Context & Motivation / 背景与动机
This PR accompanies the backend PR
OpenListTeam/OpenList(which introduces asynchronous context decoupling, force-refresh cache invalidation, and singleflight deduplication for storage quota probing).It adds the corresponding English i18n labels in
src/lang/en/settings.jsonfor the two newly introduced configuration options in the Admin Settings panel:本 PR 配合后端
OpenListTeam/OpenList的存储容量探测优化,在src/lang/en/settings.json中为管理后台新增的两个配置项提供标准英文国际化词条:storage_details_cooldown_seconds:"Storage details refresh cooldown (seconds)"Cooldown duration in seconds to throttle high-frequency capacity queries (defaults to 0).
存储容量刷新冷却时间(秒,默认 0 秒)。
storage_details_timeout_seconds:"Storage details background timeout (seconds)"Independent timeout duration in seconds for background storage details probing (defaults to 15s).
存储容量后台探测超时时间(秒,默认 15 秒)。
2. Changes / 变更内容
Added
storage_details_cooldown_secondsandstorage_details_timeout_secondstosrc/lang/en/settings.json.This PR has breaking changes. / 此 PR 包含破坏性变更。
This PR changes public API, config, storage format, or migration behavior. / 此 PR 修改了公开 API、配置、存储格式或迁移行为。
This PR requires corresponding changes in related repositories. / 此 PR 需要关联仓库同步修改。
Related repository PRs / 关联仓库 PR:
Related Issues / 关联 Issue
Testing / 测试
Checklist / 检查清单
prettierwhere applicable. / 我已按适用情况使用prettier格式化变更代码。AI Disclosure / AI 使用声明
Tools used / 使用工具:
Usage scope / 使用范围:
Documentation / 文档
Translation / 翻译
Review assistance / 审查辅助
I have reviewed and validated all AI-assisted content included in this PR. / 我已审核并验证此 PR 中的所有 AI 辅助内容。
I have ensured that all AI-assisted commits include
Co-Authored-Byattribution. / 我已确保所有 AI 辅助提交都包含Co-Authored-By归属信息。I can reproduce all AI-assisted content included in this PR without any AI tools. / 我可以在没有任何 AI 工具的情况下重现此 PR 中包含的所有 AI 辅助内容。