Repository navigation
Drop an app-supplied IDFA that matches the device's in any case - #97
Open
jrosendahl-opt wants to merge 1 commit into
Open
jrosendahl-opt wants to merge 1 commit into
jrosendahl-opt wants to merge 1 commit into
Conversation
enrichIfNeeded compared the app's .appleIDFA values to the system IDFA's uppercase uuidString exactly, so a lowercase (or space-padded) copy of the same IDFA wasn't removed and the request carried two identical a: IDs once encoded. Compare the encoded identifiers instead, as the Android SDK does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When ATT allows it, the SDK prepends the device's IDFA and removes any copy of it the app passed in. That comparison was an exact match against
uuidString, which is uppercase. If an app passes the same IDFA in lowercase or with whitespace, the copy isn't removed. Both are then encoded to the samea:<lowercased>value, so the request carries the ID twice. The Android SDK compares after normalizing and doesn't have this problem.