Skip to content

Drop an app-supplied IDFA that matches the device's in any case #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrosendahl-opt wants to merge 1 commit into
base: master
Choose a base branch
from
+25 −2
Open

Drop an app-supplied IDFA that matches the device's in any case #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Source/OptableSDK.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,9 +440,10 @@ extension OptableSDK {
ATT.advertisingIdentifier != UUID(uuid: uuid_t(0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0)) {
let systemIDFA = ATT.advertisingIdentifier.uuidString

// Remove all matching systemIDFA (deduplicate)
// Remove all matching systemIDFA (deduplicate), compared as encoded so case and whitespace don't matter
let systemEID = OptableIdentifier.appleIDFA(systemIDFA).extendedIdentifier
ids.removeAll { id in
if case let .appleIDFA(value) = id { return value == systemIDFA }
if case .appleIDFA = id { return id.extendedIdentifier == systemEID }
return false
}

Expand Down
22 changes: 22 additions & 0 deletions Tests/Unit/OptableSDKHelpersIdentifiersEnrichmentTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,28 @@ class OptableSDKHelpersIdentifiersEnrichmentTests: XCTestCase {
}
}

func test_idfa_detection_enabled_enrich_system_idfa_same_as_lowercased_user_idfa_prepend() {
ATT.advertisingIdentifierAvailable_DebugOverride = true
ATT.advertisingIdentifier_DebugOverride = UUID(uuidString: systemIDFA)

var identifiers = buildIdentifiers()
identifiers.append(.appleIDFA(" " + systemIDFA.lowercased()))

let sdk = buildSDK()
sdk.config.skipAdvertisingIdDetection = false
sdk.enrichIfNeeded(ids: &identifiers)

if case let .appleIDFA(value) = identifiers[0] {
XCTAssert(value == systemIDFA, "Prepended IDFA is not the same as system provided")
} else {
XCTFail("System IDFA is not prepended")
}

if identifiers.count(where: { if case .appleIDFA = $0 { return true } else { return false } }) > 1 {
XCTFail("User IDFA persists. (duplicate)")
}
}

func test_idfa_detection_enabled_enrich_system_idfa_user_idfa_persist() {
ATT.advertisingIdentifierAvailable_DebugOverride = true
ATT.advertisingIdentifier_DebugOverride = UUID(uuidString: systemIDFA)
Expand Down
Loading