build: pin pnpm 10 via packageManager so Dependabot and CI agree - #127
Merged
Merged
Conversation
Dependabot picks its own pnpm version when none is pinned and has started regenerating lockfiles with pnpm 11, which no longer reads pnpm.overrides from package.json. That drops the qs override from pnpm-lock.yaml, and CI's pnpm 9 then fails every frozen install with ERR_PNPM_LOCKFILE_CONFIG_MISMATCH (seen on PRs #120 and #126). Pin pnpm@10.34.5 in packageManager, which both Dependabot and pnpm/action-setup honor, and drop the hardcoded version input from the workflows since action-setup refuses to have both. pnpm 10 is the version that wrote the current lockfile and still reads the package.json overrides. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot picks its own pnpm version when none is pinned and has started regenerating lockfiles with pnpm 11, which no longer reads
pnpm.overridesfrompackage.json. That drops theqsoverride section frompnpm-lock.yaml, and CI's pnpm 9 then fails every frozen install withERR_PNPM_LOCKFILE_CONFIG_MISMATCH. This hit #120 and #126 and will hit every future Dependabot PR until the version is pinned.What
"packageManager": "pnpm@10.34.5"to the rootpackage.json. Both Dependabot andpnpm/action-setuphonor it.version: 9input from every workflow, sincepnpm/action-setup@v4errors when both aversioninput andpackageManagerare present.pnpm 10 is the version that wrote the current lockfile (it carries the
libcfields pnpm 9 does not emit) and it still reads thepackage.jsonoverrides.Verification
corepack pnpm install --frozen-lockfilewith pnpm 10.34.5 succeeds against the unchanged lockfile, with no ignored build scripts.🤖 Generated with Claude Code