Repository navigation
fix(web): a palette search that fails says so, with Retry, instead of "No results" (TASK-3587) - #2063
Merged
Merged
Conversation
… "No results" (TASK-3587) From the day-91 outside review. A server-search failure cleared the results and totals, so the empty branch rendered `No results for "…"`: a network blip read as the user's knowledge having vanished. - Primary server search (body: queries, cold index) fails: an alert, "Search couldn't finish. Check your connection and try again.", with Retry re-running the query; the live region says the same. Stale rows from an earlier query are still cleared. - The content-search supplement fails: local results stay, with a quiet "Couldn't search item content. Retry"; with no local hits, an alert says there were no title matches and content could not be searched. - Load more fails: the results shown stay, with a quiet line. CommandPalette.searchFailed.svelte.test.ts: the four failure paths plus a control (an empty answer still says "No results"); against main's palette the three failure tests go red and the control stays green. Full vitest 5735/5735, check 0 errors, palette e2e (7 specs) 33 passed. Claude-Session: https://claude.ai/code/session_01FAVXA5mJ5BNhKmv95jxQkQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the day-91 outside review. A server-search failure cleared the results
and totals, so the empty branch rendered
No results for "…": a networkblip read as the user's knowledge having vanished.
"Search couldn't finish. Check your connection and try again.", with Retry
re-running the query; the live region says the same. Stale rows from an
earlier query are still cleared.
"Couldn't search item content. Retry"; with no local hits, an alert says
there were no title matches and content could not be searched.
CommandPalette.searchFailed.svelte.test.ts: the four failure paths plus a
control (an empty answer still says "No results"); against main's palette
the three failure tests go red and the control stays green. Full vitest
5735/5735, check 0 errors, palette e2e (7 specs) 33 passed.
https://claude.ai/code/session_01FAVXA5mJ5BNhKmv95jxQkQ