Repository navigation
fix(authority): compare temporal scope bounds as instants - #125
Draft
RecursiveIntell wants to merge 1 commit into
Draft
RecursiveIntell wants to merge 1 commit into
RecursiveIntell wants to merge 1 commit into
Conversation
૮ >ﻌ< ა ci reviewran on 6f1b1a1 — fix(authority): compare temporal scope bounds as instants
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Temporal attenuation currently compares normalized ISO timestamps as strings. A whole-second upper bound such as
00:00:00Zincorrectly admits a later child bound00:00:00.100000Z, and same-second interval validation can reverse chronological order. Compare parsed UTC instants while preserving timestamp wire spelling and digest inputs.Related Issue
Source-supported pure authority review finding. No deployed consumer or attribution to the active Ares incident has been established.
Type of Change
Changes Made
ares_runtime/authority.py: compare interval order and both subset bounds as UTC datetimes; reject widening before delegation charging.How to Test
Exact focused tree
213ed87cd4f695c0e96e3f274838e39d464bfddfpassed 37 tests, zero failures, three files, one worker and zero retries. Original implementation with the same final new test file has ten causal failures and six passing controls. A fresh independent source reviewer found no blocking findings.Linux offline execution used a disposable source copy, hidden real home, temporary stores and Python network denial. A task-only interpreter shim skipped the optional bytecode cache prebuild for disk headroom; the canonical per-file runner and tests were unchanged. Source/index hashes stayed stable. Full-suite, installed application, provider/MCP and cross-platform runtime checks were not exercised.
Checklist
Evidence and Rollback
Base
04997747879d54a242941d344c3a38293c307076, treecbabd9591dc00fdf8deed90aeb3e8b1dc5bd2ebc. Exact forward/reverse index replay restored the base. Reverse delta SHA256:7c0900fb9d118d189ee9433e30dab6027207fbf6e20d67d98eb8492f5c0b02b6.Draft source proposal only. A future authorized rollback is reverting this focused commit; no activation, service, installed profile or live rollback action accompanies publication.