fix(episode): forward-sync metadata equality trait - #5
Draft
RecursiveIntell wants to merge 2 commits into
Draft
RecursiveIntell wants to merge 2 commits into
RecursiveIntell wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and dependency
One bounded trait-surface forward-sync from committed Libraries
semantic-memorymainc77273a808242c8159288ef5cf04a0a50ba6e808: derivePartialEqforEpisodeMetainsrc/types.rs, matching the owner's exact derive line. Addtests/episode_meta_trait.rsto exercise equality, inequality after a field change, and unchanged JSON fields. Add its focused test to the pinned paired-root workflow. This draft stacks onsemantic-memorydraft PR #4 at591f1cd0f6e18229780328df0c557213391d1901, itself dependent on #3 and #2. No episode bitemporal-query implementation, store migration, wire-version change, merge or activation.Evidence boundary
The owner source at the named Libraries commit contains the exact
EpisodeMetaderive line; the mirror candidate adds that line. The new trait test first failed to compile against the mirror parent becauseEpisodeMetalackedPartialEq(E0369 at both equality assertions). Controller-local validation then ran in a disposable paired root using the workflow-pinned Libraries0b099ec416de60f6adafb182f1d1e83795d05c56and candidate source/test bytes: one focused trait test; 11episode_identitytests; all-targets suite (120 library passed, three ignored, plus integration targets); formatting; strict all-targets Clippy; and Cargo package archive/verification. The controller's scratch-lock check reported exactly the paired-root script's declared PolyKV drop. Cargo warned that lockedchacha20 v0.10.1is yanked. These controller-local paired-root results were not an independent reviewer rerun. Hosted paired-root run 36432182179 subsequently completed success at exact PR heada0e28f9c30b7b5dc396eae120de96eab52de8c12with the same pinned Libraries0b099ec416de60f6adafb182f1d1e83795d05c56: the library lane passed 120 with three ignored; FK integration passed five; the new trait integration test passed one; and Cargo archived 173 files and compiled package verification. The scratch lock delta check passed. A later hosted paired-root run 36434587563 completed success at updated PR headf2df66bd0001fabf8675e250f3fa3f5a2fbe52de. After packaging, this workflow extracted the generated.crateto a separate temporary directory and ran Cargo metadata plus the full all-targets suite against that extracted package root; its library lane again passed 120 with three ignored and the integration targets passed. This is proof for the generated package artifact, not the raw Git checkout. The existing workflow pin is older than Libraries main and is unchanged.PartialEqexposes structural value equality; it does not establish canonical episode identity, temporal truth, digest equivalence, or full semantic parity. The standalone checkout still fails Cargo metadata becauseblake3inherits a workspace dependency without a workspace root. This PR is not standalone release-readiness proof. If rejected, the proposed rollback is to close this draft or revert its two scoped commits; no rollback has been performed.