Repository navigation
#9: Virtual and concrete MCP servers (concrete servers: rename and tool override) - #10
Merged
jayjfletcher merged 15 commits intoOct 27, 2026
Conversation
…erver domain to ConcreteServer Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…shims Lazy autoload fallback for the old Domains\McpServer prefix (src/Domains/ConcreteServer/shims.php, listed in autoload.files): aliases Support\Server, Concerns\HasVersionedInstructions, the two models and the two policies on request, and logs '<old> moved to <new>' for other old names. Also commits the group 9 composer.json edits (keen in require-dev, its VCS repository, dump-autoload first in the test script). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… remap Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…I checks Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…n, registry and tool-override storage Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…n, registry and tool-override storage A throwing tools-column check reads as no tool override for that call (D-055): McpToolOverrides warns through WarningLimiter (subject column-check:<exception class>, context server and message) and nothing is memoized, so the next call checks again. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ar and delete actions with policy and boot warning Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… overridden tool list Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…P surfaces and resource payload Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…P surfaces and resource payload
D-057: DELETE cortex/servers/{server}/instructions and
delete-server-instructions-tool answer 204/text when the override row is
removed, and 200 McpInstructionResource / structured content when the row
survives with its tool override.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… override editor Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…les, docs and quality gate Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
No code change: the ArchTest security-preset failure on the symlinked Atrium is the local failure D-054 accepts. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Regenerate the Ring Master block in AGENTS.md with ringside sync so the generated-files check passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayjfletcher
deleted the
ring-master/2026-10-23-1917-virtual-and-concrete-mcp-servers
branch
October 27, 2026 04:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9 (concrete half; virtual servers are a follow-up spec). Ring Master job
2026-10-23-1917-virtual-and-concrete-mcp-servers.Goal
Rename the
McpServerdomain toConcreteServerwithout breaking host servers, models, policy config or stored data, and let Cortex override the tool list of a concrete (class-based) server the way it already overrides its instructions.What's in it
src/Domains/McpServer→src/Domains/ConcreteServer. Table keys, routes, MCP tool names, config keys and server names unchanged.Support\Server,HasVersionedInstructions, the two models and their policies (autoload fallback inshims.php,@deprecated); amoved towarning for unshimmed old names; morph aliases keeping the old FQCN as the stored morph string, with a boot check;cortex.policiesentries keyed by old model FQCNs remapped with a deprecation warning.toolscolumn onmcp_instructions(idempotent migration; missing column or a throwing check degrades to code tools with a rate-limited warning);UpdateConcreteServerToolsAction/ClearConcreteServerToolsActionbehind a newupdateToolsability; serving rebuilds theServerContextwith the stored list in stored order, once per request, falling back to code tools on failure; stale, failing, ambiguous and corrupt entries are skipped and warned about through a cache-backedWarningLimiter(cortex.mcp.warning_ttl).PUT/DELETE cortex/servers/{server}/tools, MCPupdate-server-tools/clear-server-tools, resource fieldstools,tools_overridden,missing_tools,ambiguous_tools; Atrium tool editor with "restore code tools". Thecortexserver stays non-overridable.DELETE …/instructionsnow keeps a row that still holds a tool override (answers 200 with the resource then; 204 / text when the row is removed, D-057). One Keen audit entry per delete (D-056).updateToolsis open to guests; README, CHANGELOG, config banners and the Boost skill updated.refactor-circus/keeninrequire-dev,composer dump-autoloadbefore the tests, a guard that Keen tests do not skip in CI.Acceptance criteria → tests
Compat/OldNamespaceReferencesTest,McpServerRegistryTest,Http/McpInstructionsTest,Mcp/ServerInstructionToolsTestCompat/MorphAliasesTest,Compat/KeenInCiTestCompat/ClassShimsTest,tests/Fixtures/old-namespace-child.phpCompat/OldPolicyKeysTestToolsMigrationTest,McpToolOverridesTestConcreteServerToolsActionsTest,ConcreteServerToolsRaceTest,Http/ConcreteServerToolsTest,Mcp/ServerToolsToolsTest,PolicyTest,GuestToolsWarningTestMcp/ServerToolOverrideTest,Mcp/ServerToolOverrideWarningsTest,Mcp/ServerContextPinTest,Compat/OldNamespaceToolOverrideTestDeleteMcpInstructionActionTest,Http/McpInstructionsTestMcpServerRegistryTest,Unit/McpServerRegistryDefaultToolsTest,Ui/ServerToolsEditorTestConcreteServerToolsActionsTest,ConcreteServerToolsRaceTestHttp/ConcreteServerToolsTest,Mcp/ServerToolsToolsTest,Mcp/OutputSchemaTestToolOnlyRowTest,Http/ConcreteServerToolsTestMcp/ServerToolOverrideWarningsTest,WarningLimiterTest,McpToolOverridesTestConcreteServerToolsCacheTestUi/ServerToolsEditorTest,Ui/StylesTestModes/RenamedTables/RenamedTablesTestDocsTestGate (round 2):
composer testgreen: phpstan 0 errors, pint, Pest 654 tests / 2499 assertions;ringside checkpasses. Review: 2 rounds, no nits left.Before merging
CortexIntegrationmust look up the newDomains\ConcreteServer\Services\…classes. That change (b8e3477) is on Keystone branchring-master/2026-10-23-1917-cortex-concrete-server-lookup, not on Keystonemain. Merge it (and release it, if Cortex moves offdev-main) before this PR; CI here installs Keystonedev-mainfrom VCS and will look up the old class names until then.SearchRegistryno longer usesunserialize(Atriummain), which cleared the local-only ArchTest failure (D-054, D-058).🤖 Generated with Claude Code