Repository navigation
Adopt Atrium screen registry - #12
Merged
jayjfletcher merged 22 commits intoOct 30, 2026
Merged
jayjfletcher merged 22 commits into
jayjfletcher merged 22 commits into
Conversation
…ckages' UI from Roster screens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…creen on Atrium's registry (salvaged) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…creen on Atrium's registry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, with Roster's Atrium seam (salvaged) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, with Roster's Atrium seam Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd merge gate Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nd merge gate Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rganization built-in key Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rganization built-in key Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts resolved as in 458ebeb on remove-sso-and-scim, whose inputs for these files are identical. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayjfletcher
added a commit
that referenced
this pull request
Oct 30, 2026
main's side of the conflicting files equals what 458ebeb already merged here, so this branch's versions stand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayjfletcher
deleted the
ring-master/2026-10-29-2038-adopt-atrium-screen-registry
branch
November 11, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk: high
What changed
Screen::standard()and resolve through Atrium's screen registry. Views renderx-atrium::screen-tabs, tab panels and slot sections. NewScreenAccess::allowsOn()maps a record to its permission scope.Tabs,TabDefinition,TabVisibility, both partials), theactivityandmcporganization tabs, the redirect-domains card, routes and controller, and all audit trails and the History nav item.refactor-circus/atriummoves torequire-devandsuggest, with aconflicton<0.1.0. A newAtrium\AtriumServiceProvideris registered only when Atrium exists. It rebinds the invitation page (newInvitationPagecontract, plain default) and registers@rosterCan. The impersonation banner dispatches between Atrium and plain views.AtriumUnavailabletest mode, awithout-atriumCI job, new arch, composer and docs tests, and rewritten PR #4: Let host apps register tabs on organization and user screens #5 tab tests.CLAUDE.mdand CHANGELOG upgrade notes.Why
Roster rendered other packages' UI and kept its own tab registry. Atrium's screen-extensions registry (PR #16) lets any package add tabs and sections, so Roster only declares screens. Decisions that shaped it:
conflict.Look at
composer.json:47: therequiretorequire-devmove and theconflict. This is a dependency change for every consumer.src/RosterServiceProvider.php: theclass_existsstring check and$withoutAtriumgating of the seam.src/Atrium/Http/Controllers/OrganizationUiController.php: the built-in tab map,reserve()use, 403 versus default-tab handling, and data loaded only for the open tab.src/Atrium/ScreenAccess.php(allowsOn): the record-to-scope mapping, which decides what viewers see in other packages' sections.resources/views/impersonation-banner.blade.phpandresources/views/invitations/show.blade.php: published view names now point at different markup.Tested
Round 3 gate: PASS.
composer testpassed (1271 tests, coverage 100%, phpstan and pint clean).ArchTest,ScreenRegistryResetTest(Feature and Authorization).ScreenDeclarationsTest.ScreenAccessOnTest.ScreenOrderOfEvaluationTest.OrganizationTabBarTest,OrganizationRegisteredTabsTest,Modes/Keen/OrganizationActivityRemovedTest,ScreenControlsTest.RemovedIntegrationsTest,RosterPluginTest.UserPagesTest,UserRegisteredTabsTest,SharedTabBarTest.ComposerTest.ArchTest.AtriumUnavailableTest,AtriumSeamTest,InvitationPageTest,ImpersonationFlowTest.DocsTest.without-atriumjob (crit 15 and 17) andcomposer test:browser(crit 20).Risks
Screen::reserve()addition, Cortexregister-roster-redirect-domainsand Keenhistory-section-by-capability. Otherwise the activity, MCP, redirect-domain and history UI disappears with no replacement.atrium.roster.*routes unavailable without Atrium, and changed tab view variables and closure signatures. The CHANGELOG covers these.dev-mainAtrium from before PR #16 is not refused by theconflict.roster-viewskeep old views until they re-publish.standards-feedback.md.Merge blockers (criterion 21)
This PR removes the activity and MCP tabs, the redirect-domains UI and the inline audit trails in one step. Merge it only after, or in the same release as:
Screen::reserve()(commit 797d3e3)roster.organizationandroster.userBreaks
The impact stage was not run.
requiretorequire-devandsuggest, withconflictrefactor-circus/atrium<0.1.0. Without Atrium, the invitation page and impersonation banner render plain views.Atrium\Tabs,TabDefinitionandTabVisibility(PR #4: Let host apps register tabs on organization and user screens #5) are removed. Register throughAtrium::screens()->tab()instead; README "Screen extensions" covers the migration.?tab=activityand?tab=mcpnow open the default tab until Keen and Cortex register theirs.CHANGELOG.mdand the spec folder.Verified
composer test: 1271 tests passed.composer test:browser: 14 tests passed.without-atriumlane has not run yet.Spec:
docs/agent/specs/2026-10-29-2038-adopt-atrium-screen-registry/🤖 Generated with Claude Code