Repository navigation
Remove SSO and SCIM (moved to Guardian) - #13
Merged
jayjfletcher merged 20 commits intoOct 30, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…y' into ring-master/2026-10-29-2038-remove-sso-and-scim
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, surfaces, config and migrations (salvaged) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, surfaces, config and migrations Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, surfaces, config and migrations Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task 2.1: DocsTest for the Guardian CHANGELOG entry, README section, Boost skill, tab lists, Extending Roster and the agent guides. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task 2.2: CHANGELOG Breaking entry for the move to refactor-circus/guardian, README Guardian section, Extending Roster, tab lists, Boost skill, AGENTS.md (CLAUDE.md), roadmap note and the local authorization standard; ringside sync rerun. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tick tasks 2.1 to 2.3 and record group 2 in build.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Retry: verified the docs and DocsTest against criteria 14 and 15; rebuilt the PR test list and counts (692 before, 667 after); noted in build.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
main's side of the conflicting files equals what 458ebeb already merged here, so this branch's versions stand. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayjfletcher
deleted the
ring-master/2026-10-29-2038-remove-sso-and-scim
branch
November 11, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk: high
What changed
src/Domains/Ssoandsrc/Domains/Scimare deleted. That covers their providers, actions, models, policies, events, routes, the 10 MCP tools,DescribesSsoConnectionand the factory.SsoUiController,ScimUiControllerandresources/views/ui/ssoare gone. The organization screen keeps the tabsmembers,teams,invitations,rolesandsettings. The user overview loses its SSO identities card.ssoandscimconfig sections and the five table keys are removed. Migrations 000006 and 000007 are deleted, and the SSO/SCIM entries are dropped from the index migrations. Nothing drops, renames or alters tables or permission rows.suggestnow points torefactor-circus/guardian. The four SSO vendor packages leavesuggestandrequire-dev.NotSsoEnforcedis replaced bySupport\Rules\NoExternalSignIn, with message keyexternal_sign_in_required.The diff also contains the seams and Atrium screen-registry work, because this branch is stacked on those two specs.
Why
Guardian (
refactor-circus/guardian) now owns SSO and SCIM. Roster should no longer name them anywhere in source, config, routes, permissions, tables or vendor libraries, and existing installs must lose no data (D-001, D-004).SsoConnectionModelopens Guardian's handover gate. Apps that installed Guardian early runguardian:upgrade-from-roster.scimmembership source is shown as its raw value.NoExternalSignInrule stays in Roster.Look at
CHANGELOG.md([Unreleased] > Breaking, "SSO and SCIM moved to refactor-circus/guardian"): the upgrade steps and the fail-open warning. Check that the step order and the bold "before any migrate" step are correct.src/Support/Rules/NoExternalSignIn.php:1: the replacement forNotSsoEnforced. Check the message key and that behaviour is unchanged.database/migrations/2026_01_01_000010_add_roster_lookup_indexes.phpand2026_10_12_000001_add_roster_performance_indexes.php: only the SSO/SCIM entries are removed. Confirm nothing else changed.composer.json(suggestandrequire-dev): the four packages are dropped,requireis untouched, and the Atriumconflictis kept.src/Atrium/Http/Controllers/OrganizationUiController.php: the tab list, the permission map and the?tab=ssofallback tomembers.Tested
The round 2 gate passed:
composer testran 1286 tests with 0 phpstan errors and 100% coverage, andcomposer lint:checkandringside checkpassed.tests/Feature/RemovedSsoScimTest.php, plusArchTest.tests/Modes/Keen/KeenAuditTest.php.tests/Feature/Permission/PermissionSyncTest.php.tests/Feature/Organization/MembershipSourceTest.phpandtests/Unit/Organization/MembershipSourcesTest.php.tests/Feature/LegacySsoScimUpgradeTest.php, using thetests/Fixtures/legacy_sso_scim_schema.phpfixture.tests/Feature/ComposerTest.php.tests/Feature/NoExternalSignInTest.php.tests/Feature/DocsTest.php.Risks
Tableskeys. It could also recreate empty tables if it does not follow the CHANGELOG step.guardian:upgrade-from-roster.Domains\Sso|Scimclass, route name and permission name is removed from Roster's public surface.composer validate --strictwere not run.Prerequisites and merge order
This branch already contains #11 (auth extension seams) and #12 (adopt Atrium screen registry), merged in. Merge #11 and #12 first; this PR's diff then shrinks to the removal itself.
It ships together with the new refactor-circus/guardian package, which takes over SSO and SCIM. That package is still building, and its GitHub repository does not exist yet. Until Guardian is installed, SSO enforcement fails open (D-017); the CHANGELOG and README say so in bold.
Breaks
The impact stage was not run.
Tableskeys, and migrations 000006/000007.NotSsoEnforcedis replaced by the genericSupport\Rules\NoExternalSignIn.scimmembership source shows its raw value until Guardian registers it.Verified
composer test: 1286 tests passed.composer test:browser: 12 tests passed.Spec:
docs/agent/specs/2026-10-29-2038-remove-sso-and-scim/🤖 Generated with Claude Code