Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f5ba059
2026-10-29-2038-remove-sso-and-scim: shaped
jayjfletcher Oct 29, 2026
99eb410
2026-10-29-2038-remove-sso-and-scim: shaping decisions
jayjfletcher Oct 29, 2026
3d6451a
2026-10-29-2038-remove-sso-and-scim: spec written
jayjfletcher Oct 30, 2026
04583d5
2026-10-29-2038-remove-sso-and-scim: approved: decisions folded, tasks
jayjfletcher Oct 30, 2026
458ebeb
Merge auth-extension-seams into remove-sso-and-scim base
jayjfletcher Oct 30, 2026
b0fcfe5
Merge branch 'ring-master/2026-10-29-2038-adopt-atrium-screen-registr…
jayjfletcher Oct 30, 2026
c8d55a3
remove-sso-and-scim: building
jayjfletcher Oct 30, 2026
28a2feb
2026-10-29-2038-remove-sso-and-scim: group 1 Remove SSO and SCIM code…
jayjfletcher Oct 30, 2026
ae5ce3f
group 1: salvaged work in progress
jayjfletcher Oct 30, 2026
323b001
2026-10-29-2038-remove-sso-and-scim: group 1 Remove SSO and SCIM code…
jayjfletcher Oct 30, 2026
d18f2e8
2026-10-29-2038-remove-sso-and-scim: group 1 Remove SSO and SCIM code…
jayjfletcher Oct 30, 2026
758a771
2026-10-29-2038-remove-sso-and-scim: group 2 Upgrade docs and gate
jayjfletcher Oct 30, 2026
a56f557
2026-10-29-2038-remove-sso-and-scim: group 2 Upgrade docs and gate
jayjfletcher Oct 30, 2026
6ab1bfb
2026-10-29-2038-remove-sso-and-scim: group 2 Upgrade docs and gate
jayjfletcher Oct 30, 2026
4208fa9
2026-10-29-2038-remove-sso-and-scim: group 2 Upgrade docs and gate
jayjfletcher Oct 30, 2026
e535132
2026-10-29-2038-remove-sso-and-scim: rework round 1
jayjfletcher Oct 30, 2026
6295c38
Record factory run
jayjfletcher Oct 30, 2026
d180bd9
Record PR
jayjfletcher Oct 30, 2026
9263acf
Merge main (adopt-atrium-screen-registry, #12) into remove-sso-and-scim
jayjfletcher Oct 30, 2026
5e4e236
Fix RemovedSsoScimTest on Windows: compare forward-slash paths
jayjfletcher Oct 30, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions AGENTS.md

Large diffs are not rendered by default.

20 changes: 20 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,26 @@

### Breaking

- **SSO and SCIM moved to refactor-circus/guardian.**

**Without Guardian, organizations that enforce SSO accept password sign-in.** Roster registers no sign-in requirement of its own any more, so upgrading Roster without installing [`refactor-circus/guardian`](https://github.com/Refactor-Circus/Guardian) turns SSO sign-in and the SCIM endpoints off at once. Roster adds no guard for this; install Guardian in the same deploy.

Removed from Roster: the `Domains\Sso` and `Domains\Scim` domains (their actions, models, policies, requests, resources, events and services) and `SsoConnectionFactory`; their API routes (`roster.organizations.sso-connections.*`, `roster.sso-connections.*`, `roster.users.sso-identities.index`, `roster.sso-identities.destroy`, `roster.organizations.scim-tokens.*`, `roster.scim-tokens.destroy`), the sign-in routes (`roster.sso.*`), the SCIM 2.0 endpoints (`scim/v2/...`, `roster.scim.*`) and the `scim` route surface; the Atrium `sso` and `scim` organization tabs, the SSO connection page, the SSO identities card on the user page, and their `atrium.roster.sso*` and `atrium.roster.scim-tokens.*` routes, controllers and `ui/sso` views; the ten SSO and SCIM MCP tools (`list-sso-connections-tool` to `revoke-scim-token-tool`) and `Mcp\Concerns\DescribesSsoConnection`; the `roster.sso` and `roster.scim` config sections and the `sso_connections`, `sso_identities`, `scim_tokens`, `scim_users` and `scim_groups` keys of `roster.tables` and `Support\Tables::DEFAULTS`; the `create_roster_sso_tables` and `create_roster_scim_tables` migrations and the SSO/SCIM entries of the two index migrations; the `roster.sso` and `roster.scim` resources and the `roster.sso.view`, `roster.sso.manage` and `roster.scim.manage` permissions; the `scim` `MembershipSource` registration and the `scim_token` audit context; `NotSsoEnforced` with its `sso_required` message and the other `sso*` / `scim*` translation keys; and the `laravel/socialite`, `socialiteproviders/saml2`, `socialiteproviders/microsoft-azure` and `firebase/php-jwt` suggestions, now a single `refactor-circus/guardian` suggestion. Roster keeps the extension seams (`Roster::requireSignIn()`, `externalSignInFor()`, `provisionedStatus()`, `MembershipSources`, `Resources`, `PermissionCatalogue`) and `organizations.provisioned_status`, and drops no table, row or permission.

Upgrading:

1. Install `refactor-circus/guardian` in the same deploy as this Roster version (`composer require refactor-circus/guardian`).
2. **Before running any migrate command**, delete your published copies of `create_roster_sso_tables` and `create_roster_scim_tables`, and never roll them back, because their `down()` drops the tables. Remove the SSO/SCIM keys (`sso_connections`, `scim_tokens`, `scim_users`, `scim_groups`) from published copies of the two index migrations (`add_roster_lookup_indexes`, `add_roster_performance_indexes`), which otherwise ask `Tables` for keys it no longer has.
3. Publish and run Guardian's migrations, before running `roster:sync-permissions`. Guardian's upgrade migration renames `roster_sso_*` / `roster_scim_*` to `guardian_*` and role grants of `roster.sso.*` / `roster.scim.*` to `guardian.sso.*` / `guardian.scim.*`; it acts only once this Roster version is installed (Guardian's handover gate). **If you installed Guardian before this Roster version**, its upgrade migration already ran and skipped, so run `php artisan guardian:upgrade-from-roster` after upgrading Roster to finish the rename.
4. Move published config from `roster.sso.*` / `roster.scim.*` / `roster.tables.sso_*|scim_*` to the matching `guardian.*` keys, and check that Guardian's SCIM prefix matches what your identity providers call (Roster's default was `scim/v2`).
5. Replace `RefactorCircus\Roster\Domains\Sso|Scim\…` classes, `roster.sso.*` / `roster.scim.*` route names and permission names (`@rosterCan`, seeders) with Guardian's.
6. Replace `NotSsoEnforced` with `RefactorCircus\Roster\Support\Rules\NoExternalSignIn` (one `use` change; message key `external_sign_in_required`, with the same English text).

After upgrading:

- Old `?tab=sso` and `?tab=scim` links open the organization's default (members) tab. Guardian's tabs are `guardian.sso` / `guardian.scim`.
- Without Guardian, the five tables and their rows stay untouched, SSO sign-in and the SCIM endpoints answer 404, the three permission rows and their `admin` grants are kept and reported as unregistered by `roster:sync-permissions`, and members who joined through SCIM show their raw stored source, `scim`.
- The entries below that describe Roster's own `Domains\Sso` / `Domains\Scim` using the seams were written before this move; this entry supersedes them.
- **Roster no longer requires `refactor-circus/atrium`; require it to keep the dashboard** (`composer require refactor-circus/atrium`). Atrium moved to `suggest`. Without it the `atrium.roster.*` routes (`atrium.roster.users.index`, `atrium.roster.organizations.show`, ...) are not registered, so `route()` calls to them throw; Roster's Actions, HTTP API, MCP server, invitation page and impersonation banner work as before. Upgrading:
- **Atrium's screen registry replaces Roster's tab registry.** `RefactorCircus\Roster\Atrium\Tabs`, `TabDefinition` and `TabVisibility`, their container bindings, and the `ui/partials/tabs` and `ui/partials/registered-tab` partials are removed. Every Roster dashboard screen now declares itself to Atrium's screen extensions registry (`roster.users`, `roster.user`, `roster.organization`, `roster.team`, `roster.role`, `roster.transfer`, `roster.invitation` and the others listed under "Screen extensions" in the README), so tabs and sections can be added to any of them. Re-register a tab from `boot()` with `Atrium::screens()->tab('roster.organization', TabDefinition::make('acme.orders')->...)` (it was `app(Tabs::class)->organization(...)`) or `->tab('roster.user', ...)` (it was `->user(...)`), using `RefactorCircus\Atrium\Domains\Screens\Data\TabDefinition`, whose `label()`, `icon()`, `view()`, `component()`, `resolve()`, `permission()`, `authorize()` and `public()` work as before. `permission()` is checked by the new `ScreenAccess::allowsOn()`, in the same scope as before. In tests, use Atrium's `ResetsScreenExtensions` instead of `app(Tabs::class)->flush()`.
- **Changed view variables and closure signatures.** A tab view receives `screen`, `record` and `tab` over the resolver's data, no longer `organization` / `user`, `tabs` or `registeredTab`; a component receives only the `data` prop, no longer the record prop. Closures are `authorize(fn (Request $request, ?Model $record, Screen $screen): bool)` and `resolve(fn (?Model $record, Screen $screen): array)`; two- and one-argument closures still work. The organization and user tab bars are Atrium's `x-atrium::screen-tabs`: it shows only with two or more visible tabs and keeps the query string (except `page`) in its links; the built-in `data-testid="tab-{key}"` ids are unchanged.
Expand Down
Loading
Loading