Repository navigation
fix(solid): cap solid-js peer range at ^1 - #203
Conversation
The open-ended >= range lets solid-js 2.0.0 satisfy the peer once it is released, but these adapters are built for Solid 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWMMJ6aTSA3MvtgJWG2
🦋 Changeset detectedLatest commit: be81de5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Cap Solid peer dependency ranges .changeset/solid-js-peer-cap.md, packages/solid-hotkeys-devtools/package.json, packages/solid-hotkeys/package.json |
Both package manifests set the solid-js peer range to ^1.7.0. The changeset requests patch releases for both packages and describes the cap. |
Priority:
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Bug fix
Suggested reviewers: peyton-spencer
Merge Risk: 
Minimal · up to be81d
-
The dependency cap is correctly applied and the release metadata is complete; the change is mergeable.
Pre-merge checks: 
5
-
Full details: Description check
-
Explanation
The description clearly explains the motivation and implementation. It includes the Changes and Checklist sections and states that a changeset was added. The Release Impact section and two checklist items from the template are missing, but the description is otherwise mostly complete.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the range with care,
Solid one is listed there.
Two packages match the line,
Patch notes mark the release time.
Hop, the changeset joins the queue.
Comment @coderabbitai help to get the list of available commands.
|
🎉 This PR has been released! Thank you for your contribution! |
🎯 Changes
The Solid packages here declare an open-ended
solid-jspeer (>=1.x). Solid 2.0.0 is due shortly. Once it's taggedlatest, that range will accept it, sonpm installwill pair these Solid 1 adapters with Solid 2 without any peer warning, and they will fail at build or run time: Solid 2 removessolid-js/store,createComputed,mergeProps/splitProps,onMount,batchand more.This PR changes each range from
>=Xto^X, keeping the same lower bound, and adds a patch changeset so the cap actually ships. Solid 2 support can then come as a new adapter major on a pre-release branch, the way@tanstack/solid-router2.x and@tanstack/solid-query6.x did it.Prereleases (
2.0.0-rc.*) never matched>=1.x, which is why nobody has run into this yet.✅ Checklist
peerDependenciesranges and a changeset change; no code changes.Summary by CodeRabbit