Skip to content

enabled tristate cleanup in synthesis - #4565

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-tribuf-enablement2
Sep 25, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-tribuf-enablement2

Conversation

@jeffng-or

Copy link
Copy Markdown
Contributor

Addresses design elaboration errors for a few designs when using yosys-slang.

@jeffng-or jeffng-or self-assigned this Sep 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the synthesis flow to improve support for the slang frontend. Changes include adding logic to resolve internal tristates in the synthesis script and configuring slang-specific arguments in the design configuration. The reviewer identified a potential issue with the conditional definition of slang arguments in the configuration file due to variable loading order and suggested defining them unconditionally using the += operator to ensure proper export.

Comment thread flow/designs/asap7/aes-mbff/config.mk Outdated
code review feedback

Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
@openroad-ci
openroad-ci force-pushed the secure-tribuf-enablement2 branch from c983aa3 to f2c23b3 Compare September 25, 2026 12:37
@openroad-ci

openroad-ci commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit fbc711e · Jenkins build #2 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@maliberty
maliberty enabled auto-merge September 25, 2026 15:14
@maliberty
maliberty merged commit 9a75e58 into The-OpenROAD-Project:master Sep 25, 2026
11 of 12 checks passed
@maliberty
maliberty deleted the secure-tribuf-enablement2 branch September 25, 2026 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants