Repository navigation
Conversation
BattleSpawnFloatingIconAt and BattleSpawnFloatingIconAtPart are called from the Cho-Kyu and Kakusan magic overlays (by address); dropping static and declaring them in battle.h lets those overlays use a header prototype instead of a local one. No code change.
Contributor
Author
|
Closing this and the spell import drafts (#314 to #325) for now, following the hold on mass-importing MAGIC overlays. They were written one overlay at a time and would need a rewrite once the shared code and asset handling are settled, so there is no point keeping them on the board. I'll come back with something along the lines of the SOTN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two magic overlays (cho_kyu, kakusan) call these two functions, so they cannot be
static. This dropsstaticinbattle2.cand declares both inbattle.h. No code change.