Repository navigation
ci(13.x): use checked-in registry schema for generated checks - #2892
Merged
Merged
Conversation
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — workflow-only PR (+7/-3, two files: .github/workflows/changeset-check.yml, .github/workflows/ci.yml).
Checked:
- Makes the 13.x registry-types generated-file gate deterministic by dropping
--sync, hashing the checked-in schema, generating twice, and verifying byte-identical output. The determinism block does not flake on the// Generated at:timestamp becausewriteFileIfChangedskips writes when only the timestamp differs; the unchangedgit diff -Igate still catches real schema drift. - Changeset correctly not required —
.github/workflows/**is exempt, and the exemption is correctly extended toci.yml. - No touches to
src/lib/**,bin/**, or transport clients; witness-not-translator and official-transport rules not implicated.
No blocking or medium findings. high_risk false, gated_paths false, no author team gate. Falls through to row 9.
Base automatically changed from
conductor/repair-13x-dependency-audit
to
13.x
September 14, 2026 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the 13.x generated-file gate deterministic by generating registry types from the checked-in
schemas/registry/registry.yamlsnapshot instead of the live unpinned registry endpoint.The workflow hashes the checked-in schema, generates twice without
--sync, verifies the second output is byte-identical, and retains the tracked generated-file diff gate so meaningful schema or type drift still fails.Exact stack
conductor/repair-13x-dependency-audit)e7ab513f0e5603fef3d754b0c128cbfc008bb4bded30537c3222515b96613fbf7bb8318bbc65cbb46fcbc6b1d14e608dcfd442a2f9e1bc646cd54ca9conductor/13x-ci-enablement) — CI, CodeQL, and interop enablementEvidence
=; P2 binary patch and workflow blobs are unchangednpm ci— passednpm audit— 0 vulnerabilitiesRelease and protection boundary
This PR is workflow-only and does not change package versions, release triggers, permissions, tags, npm state, or GitHub settings. Checks remain advisory because
13.xis currently unprotected.The workflow changes cannot self-prove their new 13.x pull-request trigger on these PRs because the base workflows exclude
13.x. After P3 lands, maintainers must observe exact new checks, configure protection separately, and refresh #2890. No auto-merge is requested.