Skip to content

ci(13.x): run CI, CodeQL and interop on the maintenance branch - #2893

Merged
bokelley merged 1 commit into
13.xfrom
conductor/13x-ci-enablement
Sep 14, 2026
Merged

bokelley merged 1 commit into
13.xfrom
conductor/13x-ci-enablement

Conversation

@bokelley

@bokelley bokelley commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Run the existing full CI, CodeQL, and reference-seller interop workflows automatically for 13.x maintenance pull requests. CI and CodeQL also run on 13.x pushes for merged-head evidence; interop push execution remains delegated to the unchanged release workflow to avoid duplicate runs.

The embedded 13.x-local invariant locks the intended event, branch, and path-filter topology, including the changeset workflow. Existing jobs, permissions, concurrency, and release behavior are preserved.

Exact stack

Evidence

  • Fresh exact-head review on the merged base: the effective P3 delta is byte-identical to the previously reviewed P3 (range-diff =, patch-id 9bb280…, unchanged tree)
  • Full CI, CodeQL, and reference-seller interop self-ran on exact head e21f0706ccdbe8034e5dccffc2ede3b0ae1764c0; all 31 checks passed
  • npm ci — passed
  • npm audit — 0 vulnerabilities
  • Workflow lint — 16/16 passed
  • Embedded maintenance invariant — passed
  • Existing interop workflow test — 1/1 passed
  • Workflow-only changeset simulation — passed
  • Two offline registry generations — schema and type hashes unchanged
  • Detached normal generated-check sequence — passed with no tracked diff
  • Repository format, commitlint, and diff checks — passed
  • release.yml — unchanged

Release and protection boundary

release.yml is byte-identical to the 13.x base. This PR adds no secrets or write permissions and does not broaden release triggers. Standalone interop push is intentionally absent because the release workflow already calls reusable interop on 13.x pushes.

The new trigger behavior is proven on exact head e21f0706ccdbe8034e5dccffc2ede3b0ae1764c0: full CI, both CodeQL lanes, and all interop lanes self-ran and passed, while these workflows did not fire on #2891 or #2892. Checks remain advisory because 13.x is currently unprotected. Ruleset/settings changes remain a separate human-admin action, followed by refreshing #2890. No auto-merge was requested.

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — workflow-only PR enabling CI, CodeQL, and reference-seller interop on the 13.x maintenance branch.

Checked:

  • No Critical/High/Medium findings from the reviewer.
  • Only .github/workflows/*.yml files changed (dev tooling); no src/lib/**, bin/**, or build-affecting scripts/** touched, so no changeset required.
  • Embedded ci.yml invariant matches actual event/branch/path topology across all five workflows; require('yaml') resolves (direct dep, YAML 1.2 parser avoids the boolean-on trap).
  • release.yml untouched; no new secrets or permissions.

Gates: gated_paths false, high_risk false, no no-auto-approve team match, no prior decision. No decision-table trigger fires (rows 1–8), so this falls through to row 9 = approve.

Base automatically changed from conductor/13x-registry-determinism to 13.x September 14, 2026 11:46
@bokelley
bokelley force-pushed the conductor/13x-ci-enablement branch from 63a5b5e to e21f070 Compare September 14, 2026 11:49

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — workflows-only PR extends CI/CodeQL/interop-python/changeset-check/release coverage to the 13.x maintenance branch.

What I checked:

  • All 4 changed files are .github/workflows/*.yml — no src/lib/**, bin/**, or package.json changes, so witness-not-translator, official-transport-client, and changeset-vs-wire-impact rules do not apply.
  • No changeset required (workflows-only, correctly covered by the changeset-check exemption regex).
  • The self-testing "Verify stable maintenance workflow coverage" step's assertions match the actual on:/branches blocks across all five workflows.
  • yaml is a direct dependency resolvable after npm ci.

No critical/high/medium findings. gated_paths is false, review_decision is APPROVED, high_risk is false, no no-auto-approve team match. No rows 1–8 fire → row 9 approve. Prior decision was also a clean approve.

@bokelley
bokelley merged commit b78e148 into 13.x Sep 14, 2026
31 checks passed
@bokelley
bokelley deleted the conductor/13x-ci-enablement branch September 14, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant