Repository navigation
ci(13.x): run CI, CodeQL and interop on the maintenance branch - #2893
Merged
Merged
Conversation
This was referenced Sep 14, 2026
bokelley
marked this pull request as ready for review
September 14, 2026 11:40
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — workflow-only PR enabling CI, CodeQL, and reference-seller interop on the 13.x maintenance branch.
Checked:
- No Critical/High/Medium findings from the reviewer.
- Only
.github/workflows/*.ymlfiles changed (dev tooling); nosrc/lib/**,bin/**, or build-affectingscripts/**touched, so no changeset required. - Embedded ci.yml invariant matches actual event/branch/path topology across all five workflows;
require('yaml')resolves (direct dep, YAML 1.2 parser avoids the boolean-ontrap). - release.yml untouched; no new secrets or permissions.
Gates: gated_paths false, high_risk false, no no-auto-approve team match, no prior decision. No decision-table trigger fires (rows 1–8), so this falls through to row 9 = approve.
bokelley
force-pushed
the
conductor/13x-ci-enablement
branch
from
September 14, 2026 11:49
63a5b5e to
e21f070
Compare
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — workflows-only PR extends CI/CodeQL/interop-python/changeset-check/release coverage to the 13.x maintenance branch.
What I checked:
- All 4 changed files are
.github/workflows/*.yml— nosrc/lib/**,bin/**, orpackage.jsonchanges, so witness-not-translator, official-transport-client, and changeset-vs-wire-impact rules do not apply. - No changeset required (workflows-only, correctly covered by the changeset-check exemption regex).
- The self-testing "Verify stable maintenance workflow coverage" step's assertions match the actual
on:/branchesblocks across all five workflows. yamlis a direct dependency resolvable afternpm ci.
No critical/high/medium findings. gated_paths is false, review_decision is APPROVED, high_risk is false, no no-auto-approve team match. No rows 1–8 fire → row 9 approve. Prior decision was also a clean approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Run the existing full CI, CodeQL, and reference-seller interop workflows automatically for 13.x maintenance pull requests. CI and CodeQL also run on 13.x pushes for merged-head evidence; interop push execution remains delegated to the unchanged release workflow to avoid duplicate runs.
The embedded 13.x-local invariant locks the intended event, branch, and path-filter topology, including the changeset workflow. Existing jobs, permissions, concurrency, and release behavior are preserved.
Exact stack
ac2368851ac6a0570dad75147d10e381df476dc0(13.x)e21f0706ccdbe8034e5dccffc2ede3b0ae1764c0f43bef84f515be99c21e0051a1a945a3bd7e9668Evidence
range-diff =, patch-id9bb280…, unchanged tree)e21f0706ccdbe8034e5dccffc2ede3b0ae1764c0; all 31 checks passednpm ci— passednpm audit— 0 vulnerabilitiesrelease.yml— unchangedRelease and protection boundary
release.ymlis byte-identical to the 13.x base. This PR adds no secrets or write permissions and does not broaden release triggers. Standalone interop push is intentionally absent because the release workflow already calls reusable interop on 13.x pushes.The new trigger behavior is proven on exact head
e21f0706ccdbe8034e5dccffc2ede3b0ae1764c0: full CI, both CodeQL lanes, and all interop lanes self-ran and passed, while these workflows did not fire on #2891 or #2892. Checks remain advisory because13.xis currently unprotected. Ruleset/settings changes remain a separate human-admin action, followed by refreshing #2890. No auto-merge was requested.