Repository navigation
ci: add os and node matrix to unit test jobs - #673
Conversation
This change updates the unit test execution in CI to use a test job for all the various versions node we support, and a separate test job for all three major OSes. Coverage will only be sent off to codecov on the `ubuntu-latest` run of the `test_os` job. > [!NOTE] > We'll need to update merge checks at the point where it's ready to merge.
| - 24.0.0 | ||
| - 24 | ||
| - 25 | ||
| - 26.0.0 |
There was a problem hiding this comment.
❓ why the breakdown between the specific node version like 26.0.0 and 26? In this case we are capturing the first version of 24, 26 but the 22 minor version of 22, and then finally the latest of each of these versions.
Why not capture just the latest of the node versions we support in the range?
There was a problem hiding this comment.
22, 24, and 26 give the latest version for that major. So 26.0.0 is the first in the range, and 26 is the last in the range, so it covers the entire range we claim to support. Our package's engines is "node": ">=22.22.0". So this reflects all ranges that we claim to support. I left off min version for 23 and 25, because those are End of Life and I don't expect many people are using those.
There was a problem hiding this comment.
IMO, that's more of an argument for us to change our engines. As long as we have those versions in our engines (i.e. we claim to support them), then I think we should test that we actually do support them in some form.
jdalrymple
left a comment
There was a problem hiding this comment.
LGTM - Just questions, nothing blocking

This change updates the unit test execution in CI to use a test job for all the various versions node we support, and a separate test job for all three major OSes. Coverage will only be sent off to codecov on the
ubuntu-latestrun of thetest_osjob.Note
We'll need to update merge checks at the point where it's ready to merge.
Checklist:
Fixes #641