Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,16 +64,44 @@ jobs:
- uses: $/.github/actions/setup
- run: pnpm lint

test:
name: Test
test_node:
name: Test (Node.js ${{ matrix.node-version }})
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
node-version:
- 22.22.0
- 22
- 23
- 24.0.0
- 24
- 25
- 26.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why the breakdown between the specific node version like 26.0.0 and 26? In this case we are capturing the first version of 24, 26 but the 22 minor version of 22, and then finally the latest of each of these versions.

Why not capture just the latest of the node versions we support in the range?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22, 24, and 26 give the latest version for that major. So 26.0.0 is the first in the range, and 26 is the last in the range, so it covers the entire range we claim to support. Our package's engines is "node": ">=22.22.0". So this reflects all ranges that we claim to support. I left off min version for 23 and 25, because those are End of Life and I don't expect many people are using those.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm fair, should we just not include 23/25 to not incentivize anyone to use EoL versions? It also looks like v22 will be reaching EoL in a few months as well:

Screenshot 2026-11-15 at 9 09 28 PM

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, that's more of an argument for us to change our engines. As long as we have those versions in our engines (i.e. we claim to support them), then I think we should test that we actually do support them in some form.

- 26
steps:
- uses: $/.github/actions/setup
- run: pnpm build
- run: pnpm test

test_os:
name: Test (${{ matrix.os }})
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
os:
- macos-latest
- ubuntu-latest
- windows-latest
permissions:
id-token: write
steps:
- uses: $/.github/actions/setup
- run: pnpm build
- run: pnpm test --coverage
- uses: codecov/codecov-action@303a32d7a59b442fa8d48b6a1cc6825c09c847a5 # v7.1.1
if: success() && (matrix.os == 'ubuntu-latest')
with:
fail_ci_if_error: false
use_oidc: true
Loading