Repository navigation
test(c): increase test coverage for driver manager - #4972
Merged
Merged
Conversation
amoeba
marked this pull request as ready for review
October 28, 2026 02:03
lidavidm
approved these changes
Oct 28, 2026
lidavidm
pushed a commit
that referenced
this pull request
Nov 4, 2026
…th c++ (#4993) Updates the Rust driver manager search code to return errors and error details that match what C++ and C# do. Each test covers a case and the table below describes what changed at high level: | Test | Before | After | |---|---|---| | `test_load_from_name_missing_or_invalid_driver` | `Internal` | `NotFound`, with the path in the error | | `test_manifest_wrong_arch` | `InvalidArguments` | `NotFound`, with more detail in the error | | `test_load_dynamic_missing_driver` | `Internal` | `NotFound`, with the path in the error | | `test_empty_driver_name` | `NotFound` | `InvalidArguments`, with a clear error message | | `test_load_from_name_invalid_manifest_by_path_or_name` | `InvalidArguments` by path, `NotFound` by name | `InvalidArguments` either way, and the error includes the manifest path | | `test_relative_driver_path_disallowed` | `InvalidArguments` | `InvalidArguments`, and the error now includes the path | This PR makes the Rust column in the table on #4973 match the other columns. Continuation of: - #4972 - #4973 This PR was created by driving Opus 5.5 around. I reviewed it with GPT Sol 6.1 and Opus 5.5 and reviewed the tests myself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some basic test coverage for loading drivers by name/path. I found these gaps while working on #4971.