Skip to content

drop transformers 428 - #40719

Merged
Abacn merged 1 commit into
apache:masterfrom
aIbrahiim:drop-transformers-428
Oct 22, 2026
Merged

Abacn merged 1 commit into
apache:masterfrom
aIbrahiim:drop-transformers-428

Conversation

@aIbrahiim

Copy link
Copy Markdown
Contributor

PostCommit Python Dependency has been red as after Python 3.10 dropped, the matrix still runs a few envs that can't install on 3.11
#40704 and #40710 cover the pandas / torch floors and this PR is the leftover as transformers-428 still hits ResolutionImpossible (sentence-transformers==2.2.2 + torch<1.14), so this drop it from the matrix

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

cc: @jrmccluskey PTAK

@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.07%. Comparing base (a8d6afd) to head (ee66fa5).
⚠️ Report is 35 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #40719      +/-   ##
==========================================
+ Coverage   80.04%   80.07%   +0.02%     
==========================================
  Files         490      490              
  Lines       82916    83005      +89     
==========================================
+ Hits        66373    66467      +94     
+ Misses      16543    16538       -5     
Flag Coverage Δ
python 80.07% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @claudevdm for label python.
Backup reviewer: shunping (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, actually it seems the test still failing

@aIbrahiim

Copy link
Copy Markdown
Contributor Author

Sorry, actually it seems the test still failing

@Abacn this is a left over and follow up to #40704 and #40710 which those cover pandas/torch, this PR drops the leftover transformers-428 env so all three together fix the PostCommit Dependency install failures

@Abacn Abacn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, then let's merge this PR for now.

@Abacn
Abacn merged commit 1484637 into apache:master Oct 22, 2026
90 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants