Skip to content

drop transformers 428 #40719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 1 commit into from
Oct 22, 2026
+7 −9
Merged

drop transformers 428 #40719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_Python_Dependency.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"modification": 5
"modification": 8
}
8 changes: 3 additions & 5 deletions sdks/python/test-suites/tox/py311/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,9 @@ toxTask "testPy311tensorflow-212", "py311-tensorflow-212", "${posargs}"
test.dependsOn "testPy311tensorflow-212"
postCommitPyDep.dependsOn "testPy311tensorflow-212"

// Create a test task for each minor version of transformers
toxTask "testPy311transformers-428", "py311-transformers-428", "${posargs}"
test.dependsOn "testPy311transformers-428"
postCommitPyDep.dependsOn "testPy311transformers-428"

// Create a test task for each minor version of transformers.
// Dropped transformers-428: sentence-transformers==2.2.2 + torch<1.14 is
// ResolutionImpossible on Python 3.11 (see #30799).
toxTask "testPy311transformers-447", "py311-transformers-447", "${posargs}"
test.dependsOn "testPy311transformers-447"
postCommitPyDep.dependsOn "testPy311transformers-447"
Expand Down
6 changes: 3 additions & 3 deletions sdks/python/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,15 +503,15 @@ commands =
# Allow exit code 5 (no tests run) so that we can run this command safely on arbitrary subdirectories.
/bin/sh -c 'pytest -o junit_suite_name={envname} --junitxml=pytest_{envname}.xml -n 6 -m uses_xgboost {posargs}; ret=$?; [ $ret = 5 ] && exit 0 || exit $ret'

[testenv:py311-transformers-{428,447,latest}]
[testenv:py311-transformers-{447,latest}]
deps =
# Environment dependencies are defined in the `setenv` section and installed in the `commands` section.
pip_pre = False
extras = test
setenv =
COMMON_DEPS = tensorflow==2.12.0 protobuf==4.25.5 pip==25.0.1
# sentence-transformers 2.2.2 is the latest version that supports transformers 4.28.x
428: DEPS = sentence-transformers==2.2.2 'transformers>=4.28.0,<4.29.0' 'torch>=1.9.0,<1.14.0'
# transformers-428 dropped: sentence-transformers==2.2.2 + torch<1.14 is
# ResolutionImpossible on Python 3.11.
447: DEPS = 'transformers>=4.47.0,<4.48.0' 'torch>=1.9.0,<1.14.0'
latest: DEPS = 'transformers>=4.55.0' 'torch>=2.0.0' 'accelerate>=1.6.0'
commands =
Expand Down
Loading