Repository navigation
Conversation
…ice failures being reported as success
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
left a comment
There was a problem hiding this comment.
TL;DR
The production change and the tests are the same as #27956. Two of the new tests do not compile on camel-4.22.x, and the upgrade-guide note is in an older section.
Blockers
MiloClientProducerWriteFailureTest.java:68callssuper(new MiloClientConfiguration()). On camel-4.22.x the onlyMiloClientConnectionconstructor also takes aMonitorFilterConfiguration. The one-argument constructor came with CAMEL-25145, which is on main only.super(new MiloClientConfiguration(), new MonitorFilterConfiguration())fixes it.SubscriptionManagerExceptionPropagationTest.java:155,:173and:193callnew SubscriptionManager(config, executor, executor, 10_000). On camel-4.22.x the constructor is(MiloClientConfiguration, ScheduledExecutorService, long). The four-argument form came with CAMEL-25812 (#28111), which is on main only.new SubscriptionManager(new MiloClientConfiguration(), executor, 10_000)fixes it.
Other findings: 2
- The note
=== camel-milo - an awaited write, call or read that fails now fails the exchangeis atcamel-4x-upgrade-guide-4_22.adoc:2106, inside "Upgrading Camel 4.21 to 4.22". The change ships in 4.22.3, so the note belongs under "Upgrading from 4.22.2 to 4.22.3" (line 14). - The 4.22 guide on main does not have this note yet. It should go under "Upgrading from 4.22.2 to 4.22.3" there too. One small PR on main can add it to the 4.22 and 4.18 guides together.
The CI failure is this compile error. The build (25, false) job failed, and the JDK 17 job was cancelled after it. A re-run will not help until the tests are fixed. The rest of the code the new tests use is the same on this branch, so I expect them to pass after these two changes, but CI has not run them yet.
Reviewed with Claude Code on behalf of @davsclaus. This review was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying.
Backport of #27956
Cherry-pick of 3307540 to camel-4.22.x.
Conflicts resolved automatically by backport bot agent.
Conflict resolution: The 4.24 upgrade guide entry was moved to the 4.22 upgrade guide (since that file doesn't exist on this branch).