Skip to content

[backport camel-4.22.x] CAMEL-25694: camel-milo - fix write/call service failures being reported as success - #28367

Open
gnodet wants to merge 1 commit into
camel-4.22.xfrom
backport/27956-to-camel-4.22.x
Open

gnodet wants to merge 1 commit into
camel-4.22.xfrom
backport/27956-to-camel-4.22.x

Conversation

@gnodet

@gnodet gnodet commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Backport of #27956

Cherry-pick of 3307540 to camel-4.22.x.
Conflicts resolved automatically by backport bot agent.

Conflict resolution: The 4.24 upgrade guide entry was moved to the 4.22 upgrade guide (since that file doesn't exist on this branch).

@gnodet gnodet added the backport indicate that a Pull request is a backport from a fix from the main branch label Oct 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@davsclaus davsclaus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR

The production change and the tests are the same as #27956. Two of the new tests do not compile on camel-4.22.x, and the upgrade-guide note is in an older section.

Blockers

  • MiloClientProducerWriteFailureTest.java:68 calls super(new MiloClientConfiguration()). On camel-4.22.x the only MiloClientConnection constructor also takes a MonitorFilterConfiguration. The one-argument constructor came with CAMEL-25145, which is on main only. super(new MiloClientConfiguration(), new MonitorFilterConfiguration()) fixes it.
  • SubscriptionManagerExceptionPropagationTest.java:155, :173 and :193 call new SubscriptionManager(config, executor, executor, 10_000). On camel-4.22.x the constructor is (MiloClientConfiguration, ScheduledExecutorService, long). The four-argument form came with CAMEL-25812 (#28111), which is on main only. new SubscriptionManager(new MiloClientConfiguration(), executor, 10_000) fixes it.

Other findings: 2

  • The note === camel-milo - an awaited write, call or read that fails now fails the exchange is at camel-4x-upgrade-guide-4_22.adoc:2106, inside "Upgrading Camel 4.21 to 4.22". The change ships in 4.22.3, so the note belongs under "Upgrading from 4.22.2 to 4.22.3" (line 14).
  • The 4.22 guide on main does not have this note yet. It should go under "Upgrading from 4.22.2 to 4.22.3" there too. One small PR on main can add it to the 4.22 and 4.18 guides together.

The CI failure is this compile error. The build (25, false) job failed, and the JDK 17 job was cancelled after it. A re-run will not help until the tests are fixed. The rest of the code the new tests use is the same on this branch, so I expect them to pass after these two changes, but CI has not run them yet.


Reviewed with Claude Code on behalf of @davsclaus. This review was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying.

@davsclaus

Copy link
Copy Markdown
Contributor

@gnodet friendly ping: this one has a merge conflict, and the milo tests have the same constructor compile errors as #28368 (see the review from 2026-10-23).

Claude Code on behalf of davsclaus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport indicate that a Pull request is a backport from a fix from the main branch components docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants