Repository navigation
Conversation
…ice failures being reported as success
davsclaus
reviewed
Oct 23, 2026
davsclaus
left a comment
Contributor
There was a problem hiding this comment.
TL;DR
The production change and the tests are the same as #27956. Two of the new tests do not compile on camel-4.18.x, and the upgrade-guide note is in the 4.17 to 4.18 section.
Blockers
MiloClientProducerWriteFailureTest.java:68callssuper(new MiloClientConfiguration()). On camel-4.18.x the onlyMiloClientConnectionconstructor also takes aMonitorFilterConfiguration. The one-argument constructor came with CAMEL-25145, which is on main only.super(new MiloClientConfiguration(), new MonitorFilterConfiguration())fixes it.SubscriptionManagerExceptionPropagationTest.java:155,:173and:193callnew SubscriptionManager(config, executor, executor, 10_000). On camel-4.18.x the constructor is(MiloClientConfiguration, ScheduledExecutorService, long). The four-argument form came with CAMEL-25812 (#28111), which is on main only.new SubscriptionManager(new MiloClientConfiguration(), executor, 10_000)fixes it.
Other findings: 2
- The note
=== camel-milo - an awaited write, call or read that fails now fails the exchangeis atcamel-4x-upgrade-guide-4_18.adoc:1644, inside "Upgrading Camel 4.17 to 4.18", next to the 4.18.0 note aboutHEADER_AWAIT. The change ships in 4.18.6, so the note belongs under "Upgrading from 4.18.5 to 4.18.6" (line 14). - The 4.18 guide on main does not have this note yet. It should go under "Upgrading from 4.18.5 to 4.18.6" there too. The main PR for the 4.22 note from #28367 can add this one as well.
The CI failure is this compile error. The build (17, false) job failed, and the JDK 21 job was cancelled after it. A re-run will not help until the tests are fixed. I expect the tests to pass after these two changes, but CI has not run them yet.
Reviewed with Claude Code on behalf of @davsclaus. This review was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27956
Cherry-pick of 3307540 to camel-4.18.x.
Conflicts resolved automatically by backport bot agent.