Skip to content

ldap: use ldaps:// scheme when adding LDAP config if SSL is enabled - #14452

Open
weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:4.22-fix-ldaps
Open

weizhouapache wants to merge 1 commit into
apache:mainfrom
weizhouapache:4.22-fix-ldaps

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes the issue below:

addConfigurationInternal always built the connectivity-test provider URL with the plain ldap:// scheme, even when domain/global SSL (truststore) settings are configured, unlike LdapConfiguration.getProviderUrl() used elsewhere which already selects ldaps:// based on SSL status.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

addConfigurationInternal always built the connectivity-test provider
URL with the plain ldap:// scheme, even when domain/global SSL
(truststore) settings are configured, unlike LdapConfiguration.getProviderUrl()
used elsewhere which already selects ldaps:// based on SSL status.
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.34%. Comparing base (dfaae63) to head (261e5b1).
⚠️ Report is 367 commits behind head on main.

Files with missing lines Patch % Lines
...va/org/apache/cloudstack/ldap/LdapManagerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14452      +/-   ##
============================================
+ Coverage     18.05%   20.34%   +2.28%     
- Complexity    16320    21412    +5092     
============================================
  Files          5937     6493     +556     
  Lines        536919   597289   +60370     
  Branches      65810    74776    +8966     
============================================
+ Hits          96932   121492   +24560     
- Misses       428915   462595   +33680     
- Partials      11072    13202    +2130     
Flag Coverage Δ
uitests 4.32% <ø> (+0.28%) ⬆️
unittests 21.75% <0.00%> (+2.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
weizhouapache changed the base branch from 4.22 to main October 21, 2026 08:02
@weizhouapache weizhouapache reopened this Oct 21, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant