Skip to content

ldap: use ldaps:// scheme when adding LDAP config if SSL is enabled #14452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weizhouapache wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −1
Open

ldap: use ldaps:// scheme when adding LDAP config if SSL is enabled #14452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ns/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,8 @@
if (configuration == null) {
LdapContext context = null;
try {
final String providerUrl = "ldap://" + hostname + ":" + port;
final String protocol = LdapConfiguration.getSSLStatus(domainId) ? "ldaps://" : "ldap://";

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (smoke/test_router_dhcphosts smoke/test_router_dns smoke/test_router_dnsservice smoke/test_... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (smoke/test_router_dhcphosts smoke/test_router_dns smoke/test_router_dnsservice smoke/test_... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_persistent_networks component/test_project_configs component/test_project_l... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_persistent_networks component/test_project_configs component/test_project_l... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_project_usage component/test_protocol_number_security_group component/test_... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_project_usage component/test_protocol_number_security_group component/test_... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_mm_domain_limits component/test_mm_max_limits component/test_mm_project_lim... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_mm_domain_limits component/test_mm_max_limits component/test_mm_project_lim... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (smoke/test_list_accounts smoke/test_list_disk_offerings smoke/test_list_domains smoke/test... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (smoke/test_list_accounts smoke/test_list_disk_offerings smoke/test_list_domains smoke/test... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_acl_listvm component/test_acl_listvolume) 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_acl_listvm component/test_acl_listvolume) 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/find_hosts_for_migration component/test_acl_isolatednetwork component/test_acl_i... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/find_hosts_for_migration component/test_acl_isolatednetwork component/test_acl_i... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_acl_sharednetwork component/test_acl_sharednetwork_deployVM-impersonation c... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_acl_sharednetwork component/test_acl_sharednetwork_deployVM-impersonation c... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_lb_secondary_ip component/test_list_nics component/test_list_pod component/... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_lb_secondary_ip component/test_list_nics component/test_list_pod component/... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (smoke/test_network smoke/test_network_acl smoke/test_network_ipv6 smoke/test_network_permi... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (smoke/test_network smoke/test_network_acl smoke/test_network_ipv6 smoke/test_network_permi... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_concurrent_snapshots_limit component/test_cpu_domain_limits component/test_... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_concurrent_snapshots_limit component/test_cpu_domain_limits component/test_... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (smoke/test_accounts smoke/test_account_access smoke/test_affinity_groups smoke/test_affini... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (smoke/test_accounts smoke/test_account_access smoke/test_affinity_groups smoke/test_affini... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_regions_accounts component/test_routers component/test_snapshots component/... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_regions_accounts component/test_routers component/test_snapshots component/... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (smoke/test_cluster_drs smoke/test_dynamicroles smoke/test_enable_account_settings_for_doma... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (smoke/test_cluster_drs smoke/test_dynamicroles smoke/test_enable_account_settings_for_doma... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_egress_fw_rules component/test_invalid_gw_nm component/test_ip_reservation) 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_egress_fw_rules component/test_invalid_gw_nm component/test_ip_reservation) 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_affinity_groups_projects component/test_allocation_states component/test_as... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_affinity_groups_projects component/test_allocation_states component/test_as... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_volumes component/test_vpc component/test_vpc_distributed_routing_offering ... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build (component/test_volumes component/test_vpc component/test_vpc_distributed_routing_offering ... 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / build 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / codecov 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context

Check failure on line 183 in plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapManagerImpl.java

View workflow job for this annotation

GitHub Actions / codecov 

error: non-static method getSSLStatus(Long) cannot be referenced from a static context
final String providerUrl = protocol + hostname + ":" + port;
context = _ldapContextFactory.createBindContext(providerUrl,domainId);
configuration = new LdapConfigurationVO(hostname, port, domainId);
_ldapConfigurationDao.persist(configuration);
Expand Down
Loading