Repository navigation
fix(core): preserve retryable request signing errors - #8476
Merged
Merged
Conversation
github-actions
Bot
added
core
releases-note/fix
Xuanwo
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Observed in the GCS behavior job. Related to #8457 and #8458, which cover S3 credential failures.
Rationale for this change
The GCS version listing test failed after returning 20 entries. The connection to Google's OAuth token endpoint reset while reqsign was signing the next page request. The HTTP transport marked the failure as temporary, but OpenDAL discarded reqsign's retryable flag when wrapping the signing error, so the retry layer stopped the listing.
What changes are included in this PR?
The shared signing error conversion preserves reqsign's retryable flag.
Are there any user-facing changes?
With a retry layer configured, operations can recover from a signing failure that reqsign marks retryable. This applies to services that use the shared conversion.
Breaking changes
AI Usage Statement
gpt-6-astra)