Skip to content

fix(core): preserve retryable request signing errors #8476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xuanwo merged 2 commits into from
Nov 3, 2026
Merged

fix(core): preserve retryable request signing errors #8476

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f4aad7
fix(core): preserve retryable request signing errors
tisonkun Nov 3, 2026
fae76b7
test(core): remove the signing error flag mapping test
tisonkun Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions core/core/src/raw/http_util/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,15 @@ pub fn new_request_credential_error(err: anyhow::Error) -> Error {
.set_source(err)
}

/// Create a new error happened during signing request.
/// Wrap a signing failure, preserving reqsign's retryability when available.
pub fn new_request_sign_error(err: anyhow::Error) -> Error {
Error::new(ErrorKind::Unexpected, "signing http request")
.with_operation("reqsign::Sign")
.set_source(err)
let error = Error::new(ErrorKind::Unexpected, "signing http request");
#[cfg(feature = "reqsign")]
let error = error.with_temporary(
err.downcast_ref::<reqsign_core::Error>()
.is_some_and(reqsign_core::Error::is_retryable),
);
error.with_operation("reqsign::Sign").set_source(err)
}

/// Add response context to error.
Expand Down
Loading