Repository navigation
Conversation
This was referenced Nov 7, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Yes, I have read the contributor rules and development guide.
Is this PR related to a ticket?
Related to #3124. This is a standalone preparation step; it does not enable Spark 4.2 native types.
What changes were proposed in this PR?
Centralize the geometry representation boundary used by
Adapter,StructuredAdapter, andDfUtilsin a small version-selectedSpatialTypeSupportimplementation. The existing implementation keeps GeometryUDT schemas and JTS values. A later Spark 4.2 change can supply native conversion at this boundary without duplicating adapter logic.Preserve explicit GeometryUDT schemas, SRIDs, user data, full source rows, geography columns, and the existing null internal-geometry carrier. SQL, RDD/index, and S2 serialization remain unchanged. The build selects the legacy source by default and includes it in formatting/style checks.
Seven files: the helper, three callers, two build files, and one focused test suite.
How was this patch tested?
adapterTestScala,structuredAdapterTestScala, andadapterTestJavasuites. One existing ignored Scala test remains ignored.git diff --checkpassed. Review found no changes to the RDD/index formats or geography codec.Validation command:
mvn -pl spark/common -am verifywith the appropriate Spark/Scala profile, the three selected Scala suites, and-Dtest=adapterTestJava(the 4.1 run also usedclean).Did this PR include necessary documentation updates?
No user-visible behavior changes. The new helper documents the version-selected boundary.