Repository navigation
Ship raster (PNG) app icons — SVG-only favicon fails RBD QA and PWA install (#9) - #12
Conversation
- Add favicon-192.png and favicon-512.png generated from favicon.svg - Update index.html to link the PNG icon and bump asset versions to v=12 - Update manifest.json with PNG icons (any and any maskable purposes) - Update sw.js to cache new icons and bump cache version to v12 - Bump BUILD version in app.js to 12 Closes #9 Co-authored-by: axe-fb <33528067+axe-fb@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR adds raster (PNG) app icons to StepView to satisfy the Meta Ray-Ban Display Web App Simulator QA requirements and ensure reliable PWA installability.
Previously, StepView only shipped an SVG icon, which caused failures in environments that do not reliably render SVG favicons.
Changes:
favicon-192.pngandfavicon-512.png.index.htmlto reference the PNG icon as the primary icon while keeping the SVG as an alternate.manifest.jsonto include both PNG icons with appropriate sizes and purposes (anyandany maskable).12acrossindex.html,app.js, andsw.jsto ensure cache-busting and asset synchronization.sw.jspre-cache list to include the new PNG assets.Closes #9
PR created automatically by Jules for task 8611372254121830823 started by @axe-fb