Skip to content

Ship raster (PNG) app icons — SVG-only favicon fails RBD QA and PWA install (#9) #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Jul 12, 2026
Merged

Ship raster (PNG) app icons — SVG-only favicon fails RBD QA and PWA install (#9) #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
'use strict';

// ==================== CONFIG ====================
var BUILD = '11'; // bump every deploy — shown on Debug screen to confirm version
var BUILD = '12'; // bump every deploy — shown on Debug screen to confirm version
var STORAGE_KEY = 'stepview_v1';
var RING_CIRC = 603; // 2*pi*r, r=96
var KCAL_PER_KG_PER_KM = 0.9; // gross walking estimate
Expand Down
Binary file added favicon-192.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added favicon-512.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 3 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@
<meta name="description" content="StepView — step, distance, and calorie counter for Meta Ray-Ban Display glasses.">
<meta name="mrbd-web-app-capable" content="yes">
<title>StepView — Step, Distance & Calorie Counter</title>
<link rel="icon" type="image/png" sizes="192x192" href="favicon-192.png">
<link rel="icon" href="favicon.svg" type="image/svg+xml">
<link rel="manifest" href="manifest.json">
<link rel="stylesheet" href="styles.css?v=11">
<link rel="stylesheet" href="styles.css?v=12">
</head>
<body>
<div id="app">
Expand Down Expand Up @@ -133,7 +134,7 @@ <h1>Debug</h1>
</nav>
</div>
</div>
<script src="app.js?v=11"></script>
<script src="app.js?v=12"></script>
<div id="update-banner" class="update-banner hidden" data-action="update-refresh">
New version available! <span>Tap to update</span>
</div>
Expand Down
12 changes: 12 additions & 0 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,18 @@
"src": "favicon.svg",
"sizes": "any",
"type": "image/svg+xml"
},
{
"src": "favicon-192.png",
"sizes": "192x192",
"type": "image/png",
"purpose": "any"
},
{
"src": "favicon-512.png",
"sizes": "512x512",
"type": "image/png",
"purpose": "any maskable"
}
]
}
8 changes: 5 additions & 3 deletions sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
var CACHE_NAME = 'stepview-v11';
var CACHE_NAME = 'stepview-v12';
var ASSETS = [
'./',
'index.html',
'app.js?v=11',
'styles.css?v=11',
'app.js?v=12',
'styles.css?v=12',
'favicon.svg',
'favicon-192.png',
'favicon-512.png',
'manifest.json'
];

Expand Down
Loading