[Nyeriah]

Changes Proposed

Removes two of the Dalaran emblem exchange trades until the brackets that introduce their emblems:

• Emblem of Triumph for 1 Emblem of Frost, sold by Magister Arlan (37941) and Arcanist Uovril (37942), extended cost 2743. Restored in Bracket_80_4_1.
• Emblem of Conquest for 1 Emblem of Triumph, sold by Arcanist Miluria (35494) and Magistrix Vesara (35495), extended cost 2707. Restored in Bracket_80_3.

Bracket_0 deletes the four npc_vendor rows, and the two down files put back the stock rows from data/sql/base/db_world/npc_vendor.sql. The Conquest -> Valor and Valor -> Heroism trades are left alone.

Issues Addressed

No bracket touched these vendors, so a player holding Emblems of Frost on an earlier bracket could walk them down the chain to Conquest. This came up when the Headless Horseman's pumpkin was still paying Emblems of Frost in 80_2 (fixed in #506): several players traded them through Triumph into Conquest within minutes.

SOURCE

Emblem of Triumph arrived in 3.2 and Emblem of Frost in 3.3, along with the vendors' trades for them.

Tests Performed

Applied the Bracket_0 delete on a live realm running up to Bracket_80_2: the four rows are removed and the two vendors no longer offer the upgrades, while the Conquest -> Valor and Valor -> Heroism trades still work. The rows in both down files are identical to the stock npc_vendor rows.

How to Test the Changes

1. Enable brackets up to Bracket_80_2 and let the updater run.
2. Visit Magister Arlan or Arcanist Uovril in Dalaran: they should no longer sell Emblem of Triumph.
3. Visit Arcanist Miluria or Magistrix Vesara: they should no longer sell Emblem of Conquest.
4. Enable Bracket_80_3 and the Conquest trade comes back; enable Bracket_80_4_1 and the Triumph trade comes back.

Summary by CodeRabbit

• Gameplay
  • Adjusted the progression stages in which emblem exchanges are available. The Triumph-to-Conquest exchange is listed at vendors 35494 and 35495, and the Frost-to-Triumph exchange at vendors 37941 and 37942.

[coderabbitai]

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

• Configuration used: defaults
• Review profile: CHILL
• Plan: Advanced
• Run ID: 3c7c7fcc-068d-4df6-8127-05685cfc8d6e

📥 Commits

Reviewing files that changed from the base of the PR and between 8945abd and b31ecff.

📒 Files selected for processing: 3

• src/Bracket_0/sql/world/progression_0_npc_vendor_emblem_exchange.sql
• src/Bracket_80_3/sql/world/progression_0_npc_vendor_emblem_exchange_down_1.sql
• src/Bracket_80_4_1/sql/world/progression_0_npc_vendor_emblem_exchange_down_2.sql

+--------------------------+
| Grammarly for your code. |
+--------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}