Skip to content

Fix About layout and shared badge control symbols - #58

Merged
MetzinAround merged 1 commit into
mainfrom
fix/issue-50-about-layout
Oct 26, 2026
Merged

MetzinAround merged 1 commit into
mainfrom
fix/issue-50-about-layout

Conversation

@MetzinAround

@MetzinAround MetzinAround commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Copilot Generated

Changes

  • Put the working 3D badge left of the specifications on wide screens and above them on phones.
  • Let the unchanged introduction use the available page width.
  • Use the approved Left, Right, Select, Up, Down, and Home symbols on both the About page buttons and the 3D badge itself.
  • Read the symbols from one shared list. Keep the existing input mappings and draw the same SVG paths on the current model; no case rebuild is needed.
  • Move the zoom buttons to the top-right so they do not cover the Down mark on phones.
  • Include the shared symbol source in the Developer Simulator, which uses the same model. Its visible page controls and two-path instructions remain separate Part 5 work.

Related to #50. This covers the three open About requests only and does not close the issue.

Native stack 61 repair

Earlier combined checks (included #55)

  • Updated against main 2da92a8 without rewriting published history. All five website branches also combine without conflicts.
  • The shared deployment test now checks that required Doom verification precedes the actual build command, rather than depending on a step's display name.
  • Combined validation: 267 tests pass, both 31-page production builds pass (/ and /badger.github.io/), and 104 built-output checks pass. Workflow lint and required Doom-asset checks pass.
  • All GitHub build checks pass at this PR's saved head. Nothing has been merged or deployed.
  • Preserved main's display overlays, idle rotation, capture, multiple-pointer handling, and base-aware model loading.
  • Added the shared SVG sources to main's new Doom model host, so its 3D view does not fail when initializing the six markings.
  • About, Developer Simulator, and Doom load their actual 3D symbols on desktop/mobile in both themes. About/Simulator symbol input and release remain correct.
  • One repeated phone/prefixed About load hit a local Failed to fetch. A focused reload with network tracking passed with no failed requests, HTTP errors, or browser exceptions. Its cause was not reproduced; no source change was made to hide the failure.

Earlier focused verification

  • Production build: 23 pages.
  • All 14 focused input, model-loading, and MonaOS tests pass.
  • Desktop and phone checks pass in dark and light themes, including widths of 320, 390, 720, 1024, and 1440 pixels.
  • Checked the six actual 3D symbols, clicks on all symbols and the original five button caps, keyboard input, zoom, rotation, and Screen/Full views.
  • Native phone touch works on all six model symbols in normal and rotated views.
  • The shared Developer Simulator model loads and receives all six symbol inputs in both themes.
  • A forced model-load failure shows the existing photo fallback, hides unusable controls, and keeps all six specification groups.
  • Layout scan and whitespace check pass.

Limits

  • Local browser checks only; no physical badge, USB transfer, external gamepad, or device-motion tests.
  • Existing build warnings remain. The newer main's model behavior is preserved.
  • No firmware, app files, model binary, or new dependencies.

@MetzinAround
MetzinAround marked this pull request as ready for review October 25, 2026 02:59
Copilot AI balanced review requested due to automatic review settings October 25, 2026 02:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Shared WebGL symbol placement and pointer hit targets across all three hosts still need independent browser verification before approval.

No open issues 🎉

What changed in this PR

Addresses the three scoped About-page requests from #50 and shares badge control symbols across the About, Developer Simulator, and Doom 3D views.

Changes:

  • Places the About simulator beside specifications on wide screens and above them on phones, and removes the introduction’s width restriction.
  • Centralizes six control symbols, renders them as clickable 3D markings with existing input mappings, and moves About zoom controls to the top-right.
  • Documents the integration and updates the deployment test to match the actual build command.
File Description
tests/​doom-provisioning.test.mjs Checks asset verification precedes the build command.
src/​pages/​simulator.astro Supplies shared symbols to the Developer Simulator model.
src/​pages/​about-badge.astro Updates responsive simulator/specifications layout and introduction width.
src/​lib/​badge-editor-model.ts Renders shared SVG markings and maps clicks to existing input bits.
src/​lib/​badge-controls.ts Defines shared control icons, names, and input bits.
src/​components/​doom-simulator.astro Supplies shared symbols to the Doom model.
src/​components/​badge-os-simulator.astro Uses shared controls and repositions zoom buttons.
src/​components/​badge-control-symbols.astro Provides hidden SVG sources for model rendering.
docs/​editor.md Documents responsive layout and shared control markings.

Review effort: Balanced

@MetzinAround
MetzinAround added this pull request to stack #61 October 26, 2026 04:07
Rebuild the About layer on current main for native stack 61. Preserve the exact combined code, including the earlier merge-only fixes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 16600baa-96ad-4836-8e96-6b34a1c9fbd9
@MetzinAround
MetzinAround force-pushed the fix/issue-50-about-layout branch from 9db64a6 to 034f0b2 Compare October 26, 2026 06:04
@MetzinAround
MetzinAround merged commit 008383d into main Oct 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants