Skip to content

Clarify Simulator workflows and match badge controls - #59

Merged
MetzinAround merged 1 commit into
fix/issue-50-about-layoutfrom
fix/issue-50-simulator-guides
Oct 26, 2026
Merged

MetzinAround merged 1 commit into
fix/issue-50-about-layoutfrom
fix/issue-50-simulator-guides

Conversation

@MetzinAround

@MetzinAround MetzinAround commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Copilot Generated

Summary

  • Add the separately approved browser-only and physical-badge instructions above their relevant tools.
  • Replace collapsed USB setup with the full connection, edit/install, upload, disconnect, and computer-eject sequence.
  • Share one control component between About and the Developer Simulator: six accurate symbols, 52px buttons, 24px icons, responsive groups, and the existing input bits.
  • Preserve the editor, model, keyboard, touch, gamepad, disk safeguards, and full-screen tools. Setup text stays out of full screen so it does not consume the editing area.

Related to #50. This is a partial fix and does not close the issue.

Review dependency

Depends on #58, which supplies the shared symbol metadata and model markings. This PR is the upper layer of native GitHub stack 61, with #58 below it. It targets fix/issue-50-about-layout so its review shows only the Simulator follow-up. Review and merge from the bottom up. Let GitHub update the remaining layer after #58 merges, then confirm this PR's base, diff, and checks before merging.

Native stack 61 repair

Earlier combined checks (included #55)

  • Updated against main 2da92a8 without rewriting published history. All five website branches also combine without conflicts.
  • The shared deployment test now checks that required Doom verification precedes the actual build command, rather than depending on a step's display name.
  • Combined validation: 267 tests pass, both 31-page production builds pass (/ and /badger.github.io/), and 104 built-output checks pass. Workflow lint and required Doom-asset checks pass.
  • All GitHub build checks pass at this PR's saved head. Nothing has been merged or deployed.
  • Updated from Fix About layout and shared badge control symbols #58, including its current-main merge and Doom-host compatibility fix.
  • This PR still targets the About branch and changes exactly four files relative to it. Stack 61 links Fix About layout and shared badge control symbols #58 below Clarify Simulator workflows and match badge controls #59; no commits were changed when linking them.
  • Approved instructions, 52px controls, 24px symbols, model input, and full-screen tools pass the refreshed browser checks. Run/upload behavior is unchanged.

Earlier focused verification

  • npm run build: passes, 23 pages.
  • 16 focused input, full-screen, model-controller, and MonaOS tests pass.
  • Chromium: desktop 1440x1000 and phone 390x844 in dark and light themes; all eight normal Simulator/About cases pass.
  • All six page buttons send and release the correct input through pointer, native touch, and keyboard activation. Icons match the SVGs used by the actual 3D model.
  • Existing gamepad controls, Apps/Examples, Screen/Full, Rotate, full-screen connection tools, focus outlines, and disabled states remain usable.
  • No page overflow at 320, 390, 720, 1024, or 1440 pixels. Badge instructions fit at 200% text size and 720 pixels. Guide text contrast exceeds 4.5:1.
  • An in-memory BADGER folder proves Run and Auto-run open no file writer. Only explicit Install/Upload writes files; the unchanged companion file is preserved. Disconnect releases website access and still instructs computer eject.
  • Intentional model HTTP 503 retains the About photo fallback and hides unusable controls.

Two browser-helper timing assumptions were corrected: hidden About controls must be located before boot, and the lazy fallback image must be awaited. No website corrections were needed after browser inspection.

Existing build warnings remain. No real badge, physical USB transfer, external gamepad, device-motion, or real clipboard tests were performed.

@MetzinAround
MetzinAround marked this pull request as ready for review October 25, 2026 02:59
@MetzinAround
MetzinAround added this pull request to stack #61 October 26, 2026 04:07
avni
avni previously approved these changes Oct 26, 2026
Rebuild the Simulator layer directly on the updated About commit for native stack 61. Resolve the three overlapping follow-up files from the verified combined tree without changing its code.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 16600baa-96ad-4836-8e96-6b34a1c9fbd9
@MetzinAround
MetzinAround force-pushed the fix/issue-50-simulator-guides branch from 8a84f0a to 9ecfc32 Compare October 26, 2026 06:04
Copilot AI balanced review requested due to automatic review settings October 26, 2026 06:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes preserve existing input and upload contracts, with no unresolved blocking issues identified.

No open issues 🎉

What changed in this PR

This PR addresses the Simulator portion of #50, building on #58’s shared badge symbols to clarify editing workflows and unify controls across About and the Developer Simulator.

Changes:

  • Adds separate browser-only and physical-badge guides, including explicit upload, disconnect, and eject steps.
  • Shares six symbol-based controls with 52px buttons and 24px icons across both simulators.
  • Hides setup instructions in full screen while retaining connection and upload tools, and updates documentation.
File Description
src/​pages/​simulator.astro Adds workflow guides, shared controls, and full-screen help hiding.
src/​components/​badge-os-simulator.astro Replaces duplicated About controls with the shared component.
src/​components/​badge-controls.astro Defines reusable, accessible symbol controls and their styling.
docs/​editor.md Documents workflow guidance and shared control sizing.

Review effort: Balanced

@MetzinAround
MetzinAround dismissed avni’s stale review October 26, 2026 06:21

The merge-base changed after approval.

@MetzinAround
MetzinAround merged commit 008383d into main Oct 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants