Repository navigation
Clarify Simulator workflows and match badge controls - #59
Merged
MetzinAround merged 1 commit intoOct 26, 2026
Merged
Conversation
MetzinAround
marked this pull request as ready for review
October 25, 2026 02:59
avni
approved these changes
Oct 26, 2026
avni
previously approved these changes
Oct 26, 2026
Rebuild the Simulator layer directly on the updated About commit for native stack 61. Resolve the three overlapping follow-up files from the verified combined tree without changing its code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16600baa-96ad-4836-8e96-6b34a1c9fbd9
MetzinAround
force-pushed
the
fix/issue-50-simulator-guides
branch
from
October 26, 2026 06:04
8a84f0a to
9ecfc32
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused changes preserve existing input and upload contracts, with no unresolved blocking issues identified.
No open issues 🎉
What changed in this PR
This PR addresses the Simulator portion of #50, building on #58’s shared badge symbols to clarify editing workflows and unify controls across About and the Developer Simulator.
Changes:
- Adds separate browser-only and physical-badge guides, including explicit upload, disconnect, and eject steps.
- Shares six symbol-based controls with 52px buttons and 24px icons across both simulators.
- Hides setup instructions in full screen while retaining connection and upload tools, and updates documentation.
| File | Description |
|---|---|
src/pages/simulator.astro |
Adds workflow guides, shared controls, and full-screen help hiding. |
src/components/badge-os-simulator.astro |
Replaces duplicated About controls with the shared component. |
src/components/badge-controls.astro |
Defines reusable, accessible symbol controls and their styling. |
docs/editor.md |
Documents workflow guidance and shared control sizing. |
Review effort: Balanced
MetzinAround
dismissed
avni’s stale review
October 26, 2026 06:21
The merge-base changed after approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copilot Generated
Summary
Related to #50. This is a partial fix and does not close the issue.
Review dependency
Depends on #58, which supplies the shared symbol metadata and model markings. This PR is the upper layer of native GitHub stack 61, with #58 below it. It targets
fix/issue-50-about-layoutso its review shows only the Simulator follow-up. Review and merge from the bottom up. Let GitHub update the remaining layer after #58 merges, then confirm this PR's base, diff, and checks before merging.Native stack 61 repair
034f0b2. New head:9ecfc32.Earlier combined checks (included #55)
2da92a8without rewriting published history. All five website branches also combine without conflicts./and/badger.github.io/), and 104 built-output checks pass. Workflow lint and required Doom-asset checks pass.Earlier focused verification
npm run build: passes, 23 pages.Two browser-helper timing assumptions were corrected: hidden About controls must be located before boot, and the lazy fallback image must be awaited. No website corrections were needed after browser inspection.
Existing build warnings remain. No real badge, physical USB transfer, external gamepad, device-motion, or real clipboard tests were performed.