Repository navigation
Bump hey-sdk to v0.33.1 - #592
Conversation
9630398 to
08c981e
Compare
|
Rebased onto main to pick up the Go 1.27.3 certificate-trust fix from #593; the previously failing Security check now passes. Holding this dependency bump for SDK 0.33.1 preparation: SDK main already includes the redirected non-idempotent write replay guard (basecamp/hey-sdk#269) and the OAuth token redirect guard (basecamp/hey-sdk#271), both useful to include before the next CLI release. Once that SDK version is published, I will update this PR to it, refresh the Nix hash/model if needed, and re-run checks/reviews. No CLI release is being cut as part of this cleanup. |
A write HEY answers with a 422 now carries HEY's own reasons on the error instead of a bare "validation error" (hey-sdk#262), including for contact, draft and thread-comment writes. A raw write whose 2xx body breaks mid-read is reported as the success it was rather than a failure that invites a resend (hey-sdk#256); hey mcp's writes go through that path. A cached page revalidated by a bare 304 keeps its Link and count (hey-sdk#261), and the pin brings the kin-openapi and x/net advisory bumps (hey-sdk#258). No call site changes: the SDK's exported API is unchanged across the bump. The vendored MCP model moves to go/v0.33.0 with it (one schema annotation, no operation changes), and the Nix vendorHash follows go.sum.
08c981e to
b86187a
Compare
There was a problem hiding this comment.
🟢 Approved
The scoped updates are consistent, no blocking issues were identified, and the PR reports successful verification.
No open issues 🎉
What changed in this PR
Updates HEY CLI to SDK v0.33.1 for upstream reliability and security fixes, without changing CLI commands or call sites.
Changes:
- Updates the SDK dependency and checksums.
- Syncs embedded MCP model metadata and provenance.
- Refreshes the Nix vendor hash while preserving the CLI version.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
| nix/package.nix | Updates the dependency vendor hash. |
| internal/mcpserver/model/PROVENANCE.json | Records the SDK v0.33.1 source commit. |
| internal/mcpserver/model/openapi.json | Adds the upstream optional-pointer annotation. |
| go.sum | Updates SDK checksums. |
| go.mod | Pins SDK v0.33.1. |
Review effort: Balanced
|
Converged at 69334e0: all 35 check records are settled (31 success, 4 intentionally skipped), no failures or pending jobs, all required checks pass, and the branch is cleanly mergeable. Three orphaned in-progress check records persisted after their workflows had concluded successfully; reran those individual jobs, and they now report success. Copilot approved this exact head without findings; review threads: 0 total / 0 unresolved, no unanswered review-body findings. Cubic is unavailable because of the organization monthly quota, as documented on #593 and the SDK release PR, not an additional approval. Reviewed all 5 files in the full PR diff: SDK v0.33.1 pin/checksums, exact release provenance, the upstream optional-pointer annotation, and the verified Nix vendor hash. make check replace-check, build, Go 1.27.3 vulnerability scan, and the complete Docker Nix verification build pass. The separate older Nix Go toolchain pin still needs correction before a release; not claimed fixed here. Merging under the operator’s explicit instruction to see #592 through to merge. No CLI release is being cut. |
Summary
Move
github.com/basecamp/hey-sdk/gofrom v0.32.1 to the published v0.33.1 release, with no CLI call-site changes or new commands.What HEY CLI picks up:
apierr.FromSDKalready passes the SDK's message and hint through.Release: https://github.com/basecamp/hey-sdk/releases/tag/v0.33.1
Alongside go.mod/go.sum:
go/v0.33.1checkout. Its model content is unchanged from v0.33.0; only provenance moves for this patch.nix/package.nixvendorHash withmake update-nix-hash, including a successful verification build. Keep the CLI package version unchanged; this PR does not cut a CLI release.Verification
make check replace-check: pass (fmt, vet, lint, unit tests, skill-sync tests, tidy, CLI surface, release lockstep, no local replacements).govulncheck ./...under Go 1.27.3: no vulnerabilities affecting the CLI. One module-level advisory remains in code the CLI does not call.make build: pass.make update-nix-hash: new vendorHash verified by a successful Nix build.git diff --checkpasses.The Nix toolchain is pinned independently by flake.lock and still resolves Go 1.27.0. That pre-existing release-hardening concern is separate from this SDK bump and should be fixed before the next CLI release; this PR does not claim to fix Nix's Go toolchain.