Repository navigation
fix(crypto): Treat undefined JWK members as absent, not "undefined" - #333
Merged
andreiltd merged 4 commits intoOct 22, 2026
Merged
Conversation
VirtualTim
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://webidl.spec.whatwg.org/#js-dictionary
The spec says:
Which will return
undefinedfor a absent key.Following this, the spec mentions "if jsMemberValue is undefined but member has a default value [...]", then "Otherwise, if jsMemberValue is undefined and member is required [...]".
So for non-default, non-required keys, undefined members should be abscent.
There are 10 tests in
okp_importKey_failures_Ed25519.https.any.jsthat test this.I did not add a unit test for this, as this should be caught by
okp_importKey_failures_Ed25519.https.any.js.+10 passing test cases: