Repository navigation
test: retain verifier regression guards - #483
Merged
Merged
Conversation
Deploying podnotes with
|
| Latest commit: |
1a1dd08
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0e8a1faf.podnotes.pages.dev |
| Branch Preview URL: | https://test-verifier-guards.podnotes.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several plausible regressions passed the existing suites. Add twelve permanent cases from the independent verifier probes. They guard player fullscreen and CSS ordering, media resets and native seeks, settings sync, table-cell capture, transcript preservation and Find reset, and redundant decoding during own saves. Only test files change.
Verification
npm run lint,npm run format:check,npm run typecheck, andnpm run buildpass.npm run testpasses 2,613 tests in 124 files.npm run test:toolingpasses 13 tests.npm run docs:buildpasses all internal links and 112 legacy fragments.npm run test:e2efrom a fresh isolated vault passes 207 tests in 28 files on both Obsidian 1.14.4 and 1.13.7, each from a fresh vault.Node 22.23.2. Obsidian 1.14.4 and 1.13.7, each with its matching installer, on headless Linux. The runner used only this worktree's isolated vault,
podnotes-test-verifier-guards. Fixtures usehttp://podnotes.test:<ephemeral-port>with theplayer,media-reset,table-capture, andtranscriptfeeds, 60-second silent WAV media, and the committed WebVTT cues. The Media Session journey usespodnotes-e2e-silence.wav, a 600-second local WAV in its test sandbox.Each mutant ran alone and failed the named assertion. Every production file was restored byte for byte and checked against
origin/master. The green results use the restored production code..pn-player:fullscreeninstead of.pn-video:fullscreennone, receivedflexbuttonfrom MiniPlayer's.pn-iconbtnselector1to0.85; light text changes fromrgb(34, 34, 34)torgb(92, 92, 92)holdsMedia()with the existence ofsession0, expected at least12Outgoing, received[]Remote/{{title}}.md, receivedLocal/{{title}}.mdTypeError: cell.replaceSelection is not a functioneditor, receivednotewith a newly created episode notehttps://show.test/transcripts/1.vtt, receivedpodnotes-private-feed:ShowfindingandqueryresetThe coordinator can replay the exact mutation commands and inspect the raw failures in
.obsidian-e2e-artifacts/test1/mutate.py,mutations.json, and*-red.login this worktree. The loaded-run counts are inflake-watch.json. The full acceptance logs and decision trail are in the same directory. Both instances were stopped; the final dry runs report no PIDs.Release impact
None. No production code, schema, API, URI, or migration changes.
Note
Add regression guard tests for capture, playback, transcript, and settings
loadreset preserves the paused position (12-15s window), and switching episodes after a pending native seek persists the outgoing episode at 12s as unfinishedMacroscope summarized 1a1dd08.