fix(capture): offer Undo in a focused popout and put the caret back on Undo

[chhoumann]

Fixes #498
Fixes #499

Why

This fixes two capture Undo defects. With a popout focused, a capture saved, but its notice read "[object DocumentFragment]" and had no Undo. Obsidian shows the notice in the popout, but only takes a fragment built in the main window. After Undo of a capture that widened a table column, the caret sat before the table, so the next capture broke the table. Obsidian pads every row as the column widens, so Undo's edit spans the caret, and CodeMirror moves the caret to the edit's start.

What changed

• noticeWithUndo builds its message with createFragment() in place of activeDocument. It also stops checking on a notice once the popout that shows it closes.
• A capture keeps the caret it found in its editor. Undo puts that caret back after its edit, in that editor only.
• New journeys: J-TS-21 (Undo in a focused popout), Undo of a capture into an off-screen table cell moves the caret before the table #499 with the table in view and scrolled out of view, and a stale table cell in a focused popout.

Scope

• Undo still compares the whole note (feat(ui): add the v3 player with Chapters, Up next and capture Undo #466), and a detached cell still ends first (fix(capture): end a detached table cell before writing #494).
• With the note in two editing tabs, Undo still edits the first one, as on master. The caret comes back only when the capture went into that tab.
• With several cursors, Undo restores them all, but Obsidian makes the first one primary.

Tradeoffs

• A fragment built for the window that shows the notice is what master did, and it is the bug. Obsidian reads the message with the main window's helpers, which take only a main window fragment.
• Undo puts the caret back after its edit, because the edit moves a caret set before it to the table's start.
• Undo could also prefer the tab the capture went into over the first tab. That needs more code and only helps two tabs of one note with a widened column, so it is left out.

Blast Radius

Every capture Undo and every Undo notice take this path, in the main window too. There the notice is unchanged, and Undo now also puts the caret back. Size: 102,969 gzip bytes, +53 over master, 31 under the budget.

Verification

• The four new journeys fail on master and pass here on Obsidian 1.14.4. All 18 table journeys and J-TS-15 to J-TS-21 pass.
• npm run test:e2e on a fresh vault, Obsidian 1.14.4: 238 of 238 pass.
• Node 22.23.2: lint, format:check, typecheck, build, test (2,767), test:tooling (35) and docs:build pass. The table and capture journey files (36 tests) also pass on Obsidian 1.13.7.

Mutations, each run against the unit files for capture and the notice, and the target journeys:

Mutant	Unit tests	Journeys, Obsidian 1.14.4
Build the fragment from activeDocument (master)	Main window fragment fails	J-TS-21, stale popout cell fail
Build it with the popout's own createFragment	Pass	J-TS-21, stale popout cell fail
Check the notice only while its button is connected	Closed popout fails	Pass
No caret restore (master)	Selection Undo fails	Both #499 fail
Restore the caret before Undo's edit	Pass	Both #499 fail
Take the caret after the capture wrote	Selection Undo fails	Both #499 and J-TS-21 fail
Restore the caret in whichever editor reverts	Other tab's caret fails	Second pane fails
Skip ending a detached cell in a popout (V-494's mutant)	Pass	Stale popout cell fails

Docs at release

None. The docs do not mention capture Undo or popouts.

Before, master with a popout focused:

After:

Before, master after Undo and the next capture. The capture went before the header:

After:

---

Note

Medium Risk
Changes affect every capture Undo path and undo notices globally; behavior is well-covered by new unit and e2e tests but touches editor caret restoration and cross-window DOM.

Overview
Fixes capture Undo when a note is in a focused popout and when table column padding moves the caret after Undo.

Undo notices now build their DOM with Obsidian’s main-window createFragment() instead of the focused window’s document, so popout notices show readable text and a working Undo button instead of [object DocumentFragment]. Notice cleanup also stops polling once the popout window closes.

Capture Undo snapshots the editor’s selections at capture time and restores them after reverting the text, so a widened-table undo that spans the caret no longer leaves the cursor before the table and breaks the next capture into the cell.

Tests cover popout-focused capture/undo, caret/selection restore (including multi-tab and table scenarios), and new e2e helpers for focusing and interacting with note popout windows.

^{Reviewed by Cursor Bugbot for commit a504835. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix capture Undo to restore editor caret and work in focused popouts

• Capture Undo now records the editor's selection list before the edit and restores it after reverting, so the caret returns to its prior position. See CaptureService.Snapshot and the revertIn helper in CaptureService.ts
• Undo notices are now built with a main-window DocumentFragment instead of the active document, so Obsidian's Notice accepts them while a popout is focused. The notice cleanup poll also stops when its popout document closes, preventing a leaked timer
• Adds extensive test coverage: caret restoration on Undo, Undo after the destination tab closes, table-cell capture in scrolled views, and a full E2E journey for capture plus Undo with a focused popout
• Risk: Behavioral Change: Undo notices always render via the main window's fragment factory; check noticeWithUndo in undoNotice.ts if notice content ever depended on the active popout document

^{Macroscope summarized a504835.}

[cloudflare-workers-and-pages]

Deploying podnotes with    Cloudflare Pages

Latest commit:	a504835
Status:	✅  Deploy successful!
Preview URL:	https://ee1f6e93.podnotes.pages.dev
Branch Preview URL:	https://fix-capture-undo-popout.podnotes.pages.dev

View logs