Repository navigation
Deprecate Obvs.Serialization.MessagePack (MsgPack.Cli) - #96
Closed
christopherread wants to merge 1 commit into
Closed
christopherread wants to merge 1 commit into
christopherread wants to merge 1 commit into
Conversation
MsgPack.Cli hasn't had a release since 2019. Mark the package's public types and SerializedAsMsgPack() [Obsolete] (as a warning), pointing to Obvs.Serialization.MessagePack-CSharp, and say so in the package description, release notes and README. Fixes #79 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Combined into #104, which includes this change as its own commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79 (code side; see the action needed below).
Changes
[Obsolete](warning, not error) onMsgPackMessageSerializer,MsgPackMessageDeserializer<T>,MsgPackMessageDeserializerFactoryandSerializedAsMsgPack(). The message points toObvs.Serialization.MessagePack-CSharpandSerializedAsMessagePackCSharp().TestMsgPackSerializationdisables CS0618, because it exercises the deprecated serializer on purpose.MsgPack.Cli hasn't had a release since February 2019. The MessagePack-CSharp package covers the same format with a maintained library (MessagePack 3.x since #67). Existing users get a compiler warning and nothing breaks.
A package owner has to mark the package itself deprecated in the nuget.org UI; CI can't do it. Signed in as
inter8ection:Obvs.Serialization.MessagePack→ Deprecation.Obvs.Serialization.MessagePack-CSharp.Tests (written first)
ShouldBeObsoleteInFavourOfMessagePackCSharp: the three types carry a warning-level[Obsolete]naming the replacement.FluentConfigShouldBeObsoleteInFavourOfMessagePackCSharp: the fluent extension namesSerializedAsMessagePackCSharp.All 4 failed before the change and pass after. All 128 unit tests pass, and the build has no new warnings.
🤖 Generated with Claude Code