Repository navigation
Combined: broker tests in CI, ActiveMQ image, MsgPack deprecation, Elasticsearch and NATS.Net ports, Kafka subscribe fix - #104
Merged
Conversation
Fixes #74 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes #76 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes #79 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fixes #78 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eived Also drop the CI broker warm-up that hid the problem; only the topic is created up front now. Expected to fail until #103 is fixed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Subscribe returned as soon as the consumer called Subscribe, before Kafka assigned partitions, and "latest" was only resolved later, so messages published in between were skipped. Now Subscribe waits (up to 30s) for partition assignment, and the assignment handler fixes each partition's start offset there and then: the group's committed offset, or else the current end of the log. Fixes #103 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
christopherread
marked this pull request as ready for review
October 25, 2026 15:21
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines five reviewed PRs into one, so
mastergets a single merge and NuGet a single release, and adds a fix for #103. Each original PR is one commit here, in order; the originals will be closed in favour of this one.Fixes #74, fixes #76, fixes #77, fixes #78, fixes #79, fixes #103.
Commits
Category=Explicittests, using the xUnit v3 syntax.apache/activemq-classic:6.2.0with admin/admin connection credentials.Obvs.Serialization.MessagePack(was Deprecate Obvs.Serialization.MessagePack (MsgPack.Cli) #96):[Obsolete]warnings pointing toObvs.Serialization.MessagePack-CSharp.Elastic.Clients.Elasticsearch9.5.3 (was Port Obvs.Monitoring.ElasticSearch from NEST to Elastic.Clients.Elasticsearch #98).ElasticsearchClientreplacesIElasticClient, andNodePoolreplacesIConnectionPool. Index names and document fields are unchanged.NATS.Client.Core3.3.1) (was Port Obvs.NATS from NATS.Client to NATS.Net #99).MessageSourceandMessagePublisheruse (INatsConnectioninstead ofLazy<IConnection>). The fluent configuration and wire format are unchanged.Subscribereturned before Kafka assigned partitions, and "latest" was only resolved later. So messages published straight after subscribing were skipped.Subscribenow waits, for up to 30 seconds, for partition assignment. The assignment handler fixes each partition's start offset there and then: the group's committed offset, or else the current end of the log.Resolving #99 with #98 needed small conflict fixes: both changed adjacent lines in
Directory.Packages.props(the Elastic line is now in alphabetical order), and #99's NATS test met #101's cancellation-token change. The library code for #96, #98 and #99 is identical to their reviewed PRs.Testing
TestMessagePublishedStraightAfterSubscribingIsReceived, publishes immediately after subscribing. The existingTestSendAndReceiveMessagealso failed without the warm-up, even after its 2-second wait.🤖 Generated with Claude Code